From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE0B5130E3C; Fri, 16 Feb 2024 17:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103595; cv=none; b=FhNjEBzAk5jBcHW7RaUbACvweH9uW/kFZcPu631kx7Gb7s0q+i9hHt8DqimnQDtovo6/wWY+zKHdQDiKimjNS4+xvgAoQFRpl9qNPPXQtHLHhC6W6QOynCP8uD9eJh6QgvOcs25zptlNwjq+oii0RDIIcOXvNpiO85yUkIWx5v0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103595; c=relaxed/simple; bh=kQ0H/sNCQPwBmNusOIBS5iWhM6nmH7hfh3eYJZ4zLjw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=drNl04cGeRDAMivqPBFn5pnZEE57qipMV2HeYtKuPFR/k3QoyJ38jR6KrZJ0hZ0aFD/gIoiSmfMOPGtzwYaTFF4FpViEuYlZnVZ5FLBdhaVgf5rp0q+DGaKdm4s0C4wr+swW2T0Im2kDglcfxlw5fNsSz79Atk2G8QdQJNQnhNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LyvjPkHR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LyvjPkHR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEAA5C433F1; Fri, 16 Feb 2024 17:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708103594; bh=kQ0H/sNCQPwBmNusOIBS5iWhM6nmH7hfh3eYJZ4zLjw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LyvjPkHRfPJnvy+KgUErXwGzLnSj9SB07qpiXXw3ah9U/PWYAwnHmimfWyoqtQ2U8 KeuN7x4lqeuJAdBPahhcQYalW0qQr4hnpqPQn0WisKo7uFTYxBhY2wrS3C+XqqLgz1 TcmebNQBsZSSWj4eMq40uno8d3Ec3Dnsu/Ox3hp40hrfELwTTWTD/DYbjHiS2HjN1U UEoo/qI8bkB9NXGs6U3o+Sq+51SN9auLEXCegGG1aVwnuAjiyaF9NoMC+9toIHrkjG l1ZR1QDVdmGXUFNXEA+u8eLmibIlKbf/DKAUCuPvLY3EBvTXG1J4SiK0Hee/apG9BY Ae/cvZmNb1Obg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rb1lu-003v2X-MX; Fri, 16 Feb 2024 17:13:12 +0000 Date: Fri, 16 Feb 2024 17:13:10 +0000 Message-ID: <86h6i849jt.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvm@vger.kernel.org, Nicholas Piggin , Michael Ellerman , Christophe Leroy , aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, Sean Christopherson , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Sebastian Ene Subject: Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs() In-Reply-To: <20240216155941.2029458-1-oliver.upton@linux.dev> References: <20240216155941.2029458-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvm@vger.kernel.org, npiggin@gmail.com, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, seanjc@google.com, pbonzini@redhat.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, sebastianene@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 16 Feb 2024 15:59:41 +0000, Oliver Upton wrote: > > The general expectation with debugfs is that any initialization failure > is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows > implementations to return an error and kvm_create_vm_debugfs() allows > that to fail VM creation. > > Change to a void return to discourage architectures from making debugfs > failures fatal for the VM. Seems like everyone already had the right > idea, as all implementations already return 0 unconditionally. > > Signed-off-by: Oliver Upton Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.