From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DFA3CB2C5; Thu, 5 Mar 2026 16:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772729514; cv=none; b=XDz9YlOWrHxtAwsbE0Ik9EQi5VW/g6jgG/rHbGafY1XiS+aY9SANxU967SEkCa4Xv4uTjxy0hYeuHUTLcJCr58K8Zkq9bM5Z0QBdDsw3v8olen4US7DIzgEU9tOeNpEJLd8a4pJNHeGu4tpraLfJGbFhBX2pZF4LO5XJlraTE9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772729514; c=relaxed/simple; bh=oqOA+tmfWR/3o3GnKvVmaJw8vJLjDXFAY6myXgfJMys=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ENupLSnYZBlPoCf4yYuXJa9U+Kxit3j4+WcHIV9JSCxHoBslMcqW7+GYSOOjFti47pgC6oM3NLpWdHNjh4YXhxATDCT3VwSvIh0cVDukwNTq7xuDMi5ew0EXBOY+JBlnL0Rp+mR+6E9buVmu4iXTxIyonqTublueO1XOUk0kiyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=moM108pl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="moM108pl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBE0C116C6; Thu, 5 Mar 2026 16:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772729514; bh=oqOA+tmfWR/3o3GnKvVmaJw8vJLjDXFAY6myXgfJMys=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=moM108plUmV/G37engsMy4GFUzqDGqzF8whhdWesfjVVbT9tInS7er92/tfDqURoY gXxTbux74YQ8hmfSphEl4EStZXsfKCcf71SmOC8x+Nw+dSDC0PICKSTecz2LBipClb s+TNSV7lh9WrMhuMLRORHcA0Rr9+mPCJ3Fez0/yv6Rh4HkpkNyB68CbwwtkS4fhAI+ SiY7qXk+y1cHJojCDdzAEFIBjxc7+fugCsgW6JoeGn434ltkjapK49/fwFPExJYJVm oit1Cd8WYK1oY320OGkhtkjftPZxwn3k2A/jg7tZ5m8lUK6UHeEaJb75pYtTHq1XWw 2TMtsFYZxG9jw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vyBvU-0000000GXE2-0TSs; Thu, 05 Mar 2026 16:51:52 +0000 Date: Thu, 05 Mar 2026 16:51:51 +0000 Message-ID: <86jyvq6wyg.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yangyicong@hisilicon.com, wangzhou1@hisilicon.com Subject: Re: [PATCH v1 0/2] KVM: arm64: Fix a couple of latent bugs in user_mem_abort() In-Reply-To: <20260304162222.836152-1-tabba@google.com> References: <20260304162222.836152-1-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yangyicong@hisilicon.com, wangzhou1@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 04 Mar 2026 16:22:20 +0000, Fuad Tabba wrote: > > Finding these issues just reinforces how fragile this 300-line function > has become. We really need to refactor it to make the state flow easier > to reason about. I'm currently putting together a series to do just that > (introducing a proper fault state object), so stay tuned for an RFC on > that front. If you have such patches, please post them sooner rather than later, even if the rework is incomplete. I'd be happy take small patches that start add infrastructure early and work out the full refactoring over time. Thanks, M. -- Without deviation from the norm, progress is not possible.