From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 092711D0DDC; Fri, 2 Aug 2024 09:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722589232; cv=none; b=CZDBCU/PRz1D2R2mgII2ObA7ozS1Jqa23DD4jQaN9hUToqDc/mWmcBLE5qRtGuS1FMFEEcmDjUm/QBES9/l37QADagKGNI6vsBYkdmnYEv0V2AU5vY7rWFUyiHwIXBa5xTPPMDuze3SaLU9v/JncsD0wMrIp5NgCTvUHrRmuFa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722589232; c=relaxed/simple; bh=LCAUnK30xDB8ecVE/x8xdfHib0sA8+f1IZAZIFEnS9Y=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Wzw1ZEMPr93vDpMG4ehlt/qRTRyRFZnOMns/gbMlHmEnhjYTaFsWIvJUmKZqUtYVbvTwUNuESWtW+jvOI5hizU1UDUMXq00UVB+5By2Eu6oEQBVbqdZbdNV1qr6+xrtqjHofGwgNoCOgaEPmKgTWUAQP27AuB8/+94n42R1MDfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZXPVSNSR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZXPVSNSR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B077C32782; Fri, 2 Aug 2024 09:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722589231; bh=LCAUnK30xDB8ecVE/x8xdfHib0sA8+f1IZAZIFEnS9Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZXPVSNSRqBLVr+7hyXlHZISMUqc+qQUEBqA2c9n8LkZyFheGoSAFqf4H5fkQ9WsRz wMIwdiHu6fw7hLhmbxnm3tS6LAlr4sh3tBfEnalRuzzYjrHmz0ewdZ4spniy+fSnMq q1fFme4nsfnwFWUjCsSlTsO/MTkQDD/AkcCCGjUEd+Jaz+bbnlVrltehrukamTC7V4 YuPVTLyxabGQ5tHPiyS6kzQLTlvjW4U0YgIzTF1eSNKxrs1zngTn6Xf4NFy9LTkaYX zT/bm8q3hcLV7SuDCzEkaNnHMTGrE7RklBgPKUo7oNJ/i1sgegnzziua46Y8HnGVBx 83By+Lvke42RQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sZo9E-0003B2-UD; Fri, 02 Aug 2024 10:00:29 +0100 Date: Fri, 02 Aug 2024 10:00:28 +0100 Message-ID: <86jzgz1eqb.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Shuah Khan , Catalin Marinas , Joey Gouly , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list In-Reply-To: <811ea0eb-bc87-4ac3-8bca-27c787e43051@sirena.org.uk> References: <20240731-kvm-arm64-fix-s1pie-test-v1-1-a9253f3b7db4@kernel.org> <86le1g19aa.wl-maz@kernel.org> <811ea0eb-bc87-4ac3-8bca-27c787e43051@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, shuah@kernel.org, catalin.marinas@arm.com, joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 01 Aug 2024 20:14:38 +0100, Mark Brown wrote: > > [1 ] > On Thu, Aug 01, 2024 at 05:45:49PM +0100, Marc Zyngier wrote: > > > Can we please switch all this stuff to symbolic naming instead of > > magic numbers? Given how much effort is going into the "automated > > generation" thing, it is mind-boggling that the tests still rely on > > handcrafted numbers. We just end-up with two different sets of bugs. > > > At the moment, the level of confidence I have in this stuff is > > sub-zero. > > Yeah, I was wondering why this wasn't using the generated values > especially given that the generated headers are available to tools - I > wasn't sure if this was a deliberate decision to cross check the data > entry or something. We've lost that battle a long time ago, given the numbers of bugs the sysreg file has had. The real reason is that the ABI reports the encoding, and that it is rather easy to just dump stuff back into the test using the script described in the very first commit for the test. Also, the test predates the generated stuff by some margin. > I'd certainly be happy to convert, though that does > seem a bit invasive for a fix. Not for a point fix, for sure. And if you do, make sure it is entirely scripted. Thanks, M. -- Without deviation from the norm, progress is not possible.