From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801D0E7B5E2 for ; Wed, 4 Oct 2023 09:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241895AbjJDJkx (ORCPT ); Wed, 4 Oct 2023 05:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232992AbjJDJkw (ORCPT ); Wed, 4 Oct 2023 05:40:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCAE9B7 for ; Wed, 4 Oct 2023 02:40:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FE66C433C7; Wed, 4 Oct 2023 09:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696412449; bh=9rUttwmbGfzvb8LTBTxttVGtVFeCBb4xuSS+asNfggc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HEbz9p8v3ic/uf56GLJx9YldqSz9UhE1QTGrXF9Mq/F8ul3mjLZ9o7fWd8WFswU2J 5305mpMjvT4ockPbfr1QVE9mQ4vCrECPTxx/TEoHWAeTQIB8e8Vjbc3Wd/TR6wZfjZ prg4qBqifHtNgDz/nsxmXxcAJFaiMoblUewPoXeNf4snaglLS8Y+6issJdw4KltYzN 8fDTAKrb6YwaYb5kSdi9O/ihrufzOoubU7mhIdwZdxy1skKo7pI0/FLytt2xxyWBF6 vZpZyvQYAIEsoH/O3RUkzZCAY1kp95Y6aZSCFSnNYYf2s87+2vL6lcGy/qODHarJgV /DhFU/hc82v8w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qnyN4-0010TH-To; Wed, 04 Oct 2023 10:40:46 +0100 Date: Wed, 04 Oct 2023 10:40:45 +0100 Message-ID: <86mswyohcy.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Cornelia Huck Subject: Re: [PATCH v11 00/12] KVM: arm64: Enable 'writable' ID registers In-Reply-To: <20231003230408.3405722-1-oliver.upton@linux.dev> References: <20231003230408.3405722-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, cohuck@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 04 Oct 2023 00:03:56 +0100, Oliver Upton wrote: > > Few more fixes that I threw on top: > > v10 -> v11: > - Drop the custom handling of FEAT_BC as it is now fixed on the arm64 > side (Kristina) > - Bikeshed on the naming of the masks ioctl to keep things in the KVM_ > namespace > - Apply more bikeshedding to the ioctl documentation, spinning off > separate blocks for the 'generic' description and the Feature ID > documentation > - Fix referencing in the vCPU features doc > - Fix use of uninitialized data in selftest We'll probably need another bit on top to deal with Kirstina's FEAT_MOPS series and make that field writable. The minor nitpicks I had notwithstanding: Reviewed-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible.