From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Jing Zhang <jingzhangos@google.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v11 05/12] KVM: arm64: Bump up the default KVM sanitised debug version to v8p8
Date: Wed, 04 Oct 2023 09:57:44 +0100 [thread overview]
Message-ID: <86pm1uojcn.wl-maz@kernel.org> (raw)
In-Reply-To: <20231003230408.3405722-6-oliver.upton@linux.dev>
On Wed, 04 Oct 2023 00:04:01 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> Since ID_AA64DFR0_EL1 and ID_DFR0_EL1 are now writable from userspace,
> it is safe to bump up the default KVM sanitised debug version to v8p8.
>
> Signed-off-by: Jing Zhang <jingzhangos@google.com>
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
The SoB sequence looks odd. Either you're the author, and Jing's SoB
shouldn't be there without a Co-DB tag, or you've lost Jing's
attribution (which sometimes happens when rebasing and squashing
patches together).
> ---
> arch/arm64/kvm/sys_regs.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 8fbfe61fe7bc..b342c96e08f4 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -1496,8 +1496,7 @@ static u64 read_sanitised_id_aa64dfr0_el1(struct kvm_vcpu *vcpu,
> {
> u64 val = read_sanitised_ftr_reg(SYS_ID_AA64DFR0_EL1);
>
> - /* Limit debug to ARMv8.0 */
> - val = ID_REG_LIMIT_FIELD_ENUM(val, ID_AA64DFR0_EL1, DebugVer, IMP);
> + val = ID_REG_LIMIT_FIELD_ENUM(val, ID_AA64DFR0_EL1, DebugVer, V8P8);
>
> /*
> * Only initialize the PMU version if the vCPU was configured with one.
> @@ -1557,6 +1556,8 @@ static u64 read_sanitised_id_dfr0_el1(struct kvm_vcpu *vcpu,
> if (kvm_vcpu_has_pmu(vcpu))
> val |= SYS_FIELD_PREP(ID_DFR0_EL1, PerfMon, perfmon);
>
> + val = ID_REG_LIMIT_FIELD_ENUM(val, ID_DFR0_EL1, CopDbg, Debugv8p8);
> +
For consistency, you should also repaint DBGDIDR, which has a
hardcoded '6' (ARMv8) as the supported debug version.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-10-04 8:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 23:03 [PATCH v11 00/12] KVM: arm64: Enable 'writable' ID registers Oliver Upton
2023-10-03 23:03 ` [PATCH v11 01/12] KVM: arm64: Allow userspace to get the writable masks for feature " Oliver Upton
2023-10-03 23:03 ` [PATCH v11 02/12] KVM: arm64: Document KVM_ARM_GET_REG_WRITABLE_MASKS Oliver Upton
2023-10-03 23:03 ` [PATCH v11 03/12] KVM: arm64: Use guest ID register values for the sake of emulation Oliver Upton
2023-10-03 23:04 ` [PATCH v11 04/12] KVM: arm64: Reject attempts to set invalid debug arch version Oliver Upton
2023-10-03 23:04 ` [PATCH v11 05/12] KVM: arm64: Bump up the default KVM sanitised debug version to v8p8 Oliver Upton
2023-10-04 8:57 ` Marc Zyngier [this message]
2023-10-04 17:08 ` Oliver Upton
2023-10-04 17:46 ` Marc Zyngier
2023-10-03 23:04 ` [PATCH v11 06/12] KVM: arm64: Allow userspace to change ID_AA64ISAR{0-2}_EL1 Oliver Upton
2023-10-03 23:04 ` [PATCH v11 07/12] KVM: arm64: Allow userspace to change ID_AA64MMFR{0-2}_EL1 Oliver Upton
2023-10-03 23:04 ` [PATCH v11 08/12] KVM: arm64: Allow userspace to change ID_AA64PFR0_EL1 Oliver Upton
2023-10-03 23:04 ` [PATCH v11 09/12] KVM: arm64: Allow userspace to change ID_AA64ZFR0_EL1 Oliver Upton
2023-10-03 23:04 ` [PATCH v11 10/12] KVM: arm64: Document vCPU feature selection UAPIs Oliver Upton
2023-10-04 9:36 ` Marc Zyngier
2023-10-04 16:52 ` Oliver Upton
2023-10-04 17:48 ` Marc Zyngier
2023-10-03 23:04 ` [PATCH v11 11/12] KVM: arm64: selftests: Import automatic generation of sysreg defs Oliver Upton
2023-10-03 23:04 ` [PATCH v11 12/12] KVM: arm64: selftests: Test for setting ID register from usersapce Oliver Upton
2023-10-04 9:40 ` [PATCH v11 00/12] KVM: arm64: Enable 'writable' ID registers Marc Zyngier
2023-10-04 16:53 ` Oliver Upton
2023-10-04 17:46 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pm1uojcn.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=cohuck@redhat.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox