From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467CBE8FDDB for ; Wed, 4 Oct 2023 08:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241844AbjJDI5v (ORCPT ); Wed, 4 Oct 2023 04:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232554AbjJDI5v (ORCPT ); Wed, 4 Oct 2023 04:57:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DB0CA9 for ; Wed, 4 Oct 2023 01:57:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E387C433C8; Wed, 4 Oct 2023 08:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696409867; bh=yH6k8GoAJwpgqGqdDVsBapQr9WwoXO3s+AZxwUytCe0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WIWP5jEKrL/AdbqLlOVHbljtYRzI47rPWzdEugupzl8YUkponrUyhoqdROyWjan+v FGjiSskgYyUz6oSH/Req8B/ddgb8JcfO/ek/i8JbAotQLWzd9YPJBSqhR7JaB6Qu7L TJkPaBH6OOTyje03vGRkwJx42Rpj8FnYpBZf2Ky0Jp8z01TVNYbWcGsTXPukUuUXi0 mTuyt0s5h4G7aUCJP0uQk+McgabQn1zQZGeLodbNnYUjcyYBXWibYVz+Wj75XDy4QG 5d3NZKn8DLgsqa2BMIxOnJmfqShpm8x8H43aznuL9B2ld0mJHcSWoyuyMT1tiv1IXP zFyO7XhKBQHjg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qnxhQ-000zUU-K3; Wed, 04 Oct 2023 09:57:44 +0100 Date: Wed, 04 Oct 2023 09:57:44 +0100 Message-ID: <86pm1uojcn.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Cornelia Huck Subject: Re: [PATCH v11 05/12] KVM: arm64: Bump up the default KVM sanitised debug version to v8p8 In-Reply-To: <20231003230408.3405722-6-oliver.upton@linux.dev> References: <20231003230408.3405722-1-oliver.upton@linux.dev> <20231003230408.3405722-6-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, cohuck@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 04 Oct 2023 00:04:01 +0100, Oliver Upton wrote: > > Since ID_AA64DFR0_EL1 and ID_DFR0_EL1 are now writable from userspace, > it is safe to bump up the default KVM sanitised debug version to v8p8. > > Signed-off-by: Jing Zhang > Signed-off-by: Oliver Upton The SoB sequence looks odd. Either you're the author, and Jing's SoB shouldn't be there without a Co-DB tag, or you've lost Jing's attribution (which sometimes happens when rebasing and squashing patches together). > --- > arch/arm64/kvm/sys_regs.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 8fbfe61fe7bc..b342c96e08f4 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -1496,8 +1496,7 @@ static u64 read_sanitised_id_aa64dfr0_el1(struct kvm_vcpu *vcpu, > { > u64 val = read_sanitised_ftr_reg(SYS_ID_AA64DFR0_EL1); > > - /* Limit debug to ARMv8.0 */ > - val = ID_REG_LIMIT_FIELD_ENUM(val, ID_AA64DFR0_EL1, DebugVer, IMP); > + val = ID_REG_LIMIT_FIELD_ENUM(val, ID_AA64DFR0_EL1, DebugVer, V8P8); > > /* > * Only initialize the PMU version if the vCPU was configured with one. > @@ -1557,6 +1556,8 @@ static u64 read_sanitised_id_dfr0_el1(struct kvm_vcpu *vcpu, > if (kvm_vcpu_has_pmu(vcpu)) > val |= SYS_FIELD_PREP(ID_DFR0_EL1, PerfMon, perfmon); > > + val = ID_REG_LIMIT_FIELD_ENUM(val, ID_DFR0_EL1, CopDbg, Debugv8p8); > + For consistency, you should also repaint DBGDIDR, which has a hardcoded '6' (ARMv8) as the supported debug version. Thanks, M. -- Without deviation from the norm, progress is not possible.