From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795269150; b=olwFWTl0jM4JpPqfHI58+091LBplmbkE8Dm7tUCeM+5dxB+BUCXmgvd/vMV0aH7s9xjQ ZuZFh2mllB07cNhmLS/XCDNEnNexcOErLq1fwrZULMRkQOTFRWmkmerW6O70wAgni83EE d1rJUFN55yVjbfMu/NyteG3xVH//AoS0svYipg4UXd2e+PwbfBi+YrTt1Bb9rd9YfH8f/ oBZxiAUz9B2jtY7RjdFVXkGcv+XEBIdzNC/uaL7XfWDSvcqxkRkwT/EVxORDma1FATTzj wCvXDovDyDJQCMnDznmu6xKj9LEsFmBJ1xR4zmleZUXZP4XmGXgRj1edyVHYuuqloJg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795269150; h=Received:DKIM-Signature:Received:Date:Message-ID:From:To:Cc:Subject: In-Reply-To:References:User-Agent:MIME-Version:Content-Type: X-SA-Exim-Connect-IP:X-SA-Exim-Rcpt-To:X-SA-Exim-Mail-From: X-SA-Exim-Scanned; bh=I/rNC1WiZD81B1MWUnQsVljik6e2kf/u4y9BCYhd1x0=; b=1z56mIBndWE0k5/EgpVj0MgoNSYjEWUy0+/R1mFyhOYrWgxAr6MXNnk7t1yE6WndnMWO KNuUoHTofC3mN3rd+ah8PHM0R+Er2O8yLeVsWOF+EcQuctIsTiDJ0ixApedRKbes9UpG+ PlI+MMbX3Em9cIbHXXUFFLjd/ho/bsDFFDjQMcFfLG5/n0BKbvTYBMngvfG19Pi80JMPR Xp/ylt4VueZiKiVVmz0fq0FE6/l5vejYYoVQm424WOdIQdmOuHlJH64C71g4Y31QncAwH Jj58RLeK3lm78PDyOrZhq+wrV9iU147T38R9G1xU8F4LrP3e6JD1n83PUiia7b1DkcA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VK+QHNyq; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DEE9606A320 for ; Sat, 21 Nov 2026 13:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VK+QHNyq Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECB601F000C6; Sat, 21 Nov 2026 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795269150; bh=I/rNC1WiZD81B1MWUnQsVljik6e2kf/u4y9BCYhd1x0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=VK+QHNyqrqC9s0fNIhyuxVpffVlB928gbe9bAkjrjvEZFBSsuaMEm/+3nB+xYm6PM VWh6HxGR/Cq99hNNRsUXSTX6JLhLKy/bz7j4zWhRZcjoRqJ3JXl+xknBwGJR3O+6QU brPvrjWYl1M2VVbSx8hzKEYtldKlS+4CW1bl/mOevdFgAuMnbr7oaRvwQojyiTNZLb 9KszQQ3AcX0fftsSx4EC/GhaSF7ruUnfDXEERzvchWDCJuJd3d6r62W63HqclUfNqO vdyrm0ZMt+VudXU0RLKCyZpbS/jHIhknsHl7kK0+1SRREYQOuc/2DUb6nKCUfhh1wP uv57dkNYgIFNA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xUlVz-00000001Md6-35ux; Sat, 21 Nov 2026 13:52:27 +0000 Date: Sat, 21 Nov 2026 13:52:27 +0000 Message-ID: <86qzgez3z8.wl-maz@kernel.org> From: Marc Zyngier To: Haseeb Ashraf Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , Paolo Bonzini , Volodymyr Babchuk , Haseeb Ashraf , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eric Auger Subject: Re: [PATCH 0/1] hw/arm/virt: add vhe option for nested virtualization In-Reply-To: <20261121095636.289814-1-haseebashraf091@gmail.com> References: <20261121095636.289814-1-haseebashraf091@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: haseebashraf091@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, pierrick.bouvier@oss.qualcomm.com, pbonzini@redhat.com, volodymyr.babchuk@epam.com, haseeb.ashraf@siemens.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, eauger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 21 Nov 2026 09:56:35 +0000, Haseeb Ashraf wrote: > > Hi, > > The virt board currently enables VHE whenever virtualization=on. There > is no way to expose EL2 in nVHE mode to a type-1 guest hypervisor. > > This series adds a vhe machine property, enabled by default for > compatibility. Setting vhe=off propagates the requested mode to the > guest CPU, limits TCG's advertised VHE feature, and requests the KVM > HAS_EL2_E2H0 vCPU initialization feature. Unsupported accelerators > and KVM hosts fail clearly instead of silently ignoring the option. + Eric Adding yet another random property for something that is a feature of the emulated CPU strikes me as going in the wrong direction. I'd rather see this being directly driven by Eric's feature framework as posted at [1], which lets *any* feature being selected by the user. The KVM feature flag can then be derived from what the user has selected (and matched against what the host can provide). Thanks, M. [1] https://lore.kernel.org/r/20261010133725.642498-1-eric.auger@redhat.com -- Without deviation from the norm, progress is not possible.