Re: [PATCH] KVM: selftests: fix ITS collection target addresses in vgic_lpi_stress

Maximilian Dittgen
2025-10-20T15:14:14Z

On Mon, 20 Oct 2025 15:01:15 +0200,
Marc Zyngier <maz@kernel.org> wrote:
>
> To be clear: I don't object to the patch. I object to the nonsensical
> commit message.
>
> And yes, what you have is the correct fix. Just wrap it as a helper
> I'd suggest procnum_to_rdbase(), if you need a name for it).

Thank you for the feedback, I've created a PATCH v2 with revised commit
message and a procnum_to_rdbase() helper.

>
> This test also violate the architecture by not performing a SYNC after
> any command, which would also require the use of a properly formatted
> target field. But hey, correctness is overrated.

I am currently working on a RFC patchset for per-vCPU vLPI enablement
that extends this selftest to test the feature. I will package in SYNCs
as a patch on the RFC.

Thanks,
Maximilian