From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [RFC PATCH 3/4] KVM: arm/arm64: Rearrange kvm_vgic_[un]map_phys code in vgic.c Date: Sat, 02 Sep 2017 12:14:28 +0100 Message-ID: <86y3pxtkrv.fsf@arm.com> References: <20170829093902.15379-1-cdall@linaro.org> <20170829093902.15379-4-cdall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Cc: kvmarm@lists.cs.columbia.edu, Eric Auger , Andre Przywara , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org To: Christoffer Dall Return-path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:45718 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdIBLOd (ORCPT ); Sat, 2 Sep 2017 07:14:33 -0400 In-Reply-To: <20170829093902.15379-4-cdall@linaro.org> (Christoffer Dall's message of "Tue, 29 Aug 2017 11:39:01 +0200") Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 29 2017 at 11:39:01 am BST, Christoffer Dall wrote: > The small indirection of a static function made the locking very obvious > but becomes pretty ugly as we start passing function pointer around. > Let's inline these two functions first to make the following patch more > readable. > > Signed-off-by: Christoffer Dall Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.