Re: [kvm-unit-tests RFC] s390x: Add Protected VM support

Christian Borntraeger
2020-05-07T12:39:59Z

On 07.05.20 14:30, Marc Hartmayer wrote:
> On Wed, May 06, 2020 at 04:03 PM +0200, Janosch Frank <frankja@linux.ibm.com> wrote:
>> On 5/6/20 2:46 PM, Marc Hartmayer wrote:
>>> Add support for Protected Virtual Machine (PVM) tests. For starting a
>>> PVM guest we must be able to generate a PVM image by using the
>>> `genprotimg` tool from the s390-tools collection. This requires the
>>> ability to pass a machine-specific host-key document, so the option
>>> `--host-key-document` is added to the configure script.
>>>
>>> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>
> […snip…]
>
>>> [intercept]
>>> file = intercept.elf
>>> +pv_support = 1
>>
>> So, let's do this discussion once more:
>> Why would we need a opt-in for something which works on all our current
>> tests? I'd much rather have a opt-out or just a bail-out when running
>> the test like I already implemented for the storage key related
>> tests...
>>
>> I don't see any benefit for this right now other than forcing me to add
>> another line to this file that was not needed before..
>>
>
> Okay. So shall I add an option ’pv_not_supported’? Or simply assume that
> the actual test cases will handle it?

I would suggest to fix the testcases (e.g. do an early exit when we are running
secure and we know it does not work)