Re: [PATCH v4 40/55] meson: link shared objects into qemu-system

[Markus Armbruster <armbru@redhat.com>]

Yonggang Luo <luoyonggang@gmail.com> writes:

> Extract common_ss, system_ss, and family-common objects into one
> qemu-system binary. Only arm, aarch64, microblaze-softmmu are
> listed; a new target must have arch_srcs equal to target_info_def
> only (target-info-def.c). Config headers stay in arch_genh.
>
> - Union non-TARGET_* keys with y taking precedence
> - Reject leftover arch_srcs on participating targets
> - Reject TARGET_* conditions on common_ss and system_ss
> - Link SDL, install the binary, and apply Darwin entitlements
>
> Adding a target that still has per-target sources fails meson, for
> example:
>
>   combined qemu-system leftover for :
>   expected:
>   target-info-def.c
>   arch_srcs:
>   target/microblaze/mmu.c
>   target/microblaze/machine.c
>   target-info-def.c
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>

Watch query-target lie:

    $ qemu-system -S -nodefaults -display none -qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 11}, "package": "v11.1.0-1902-g88f617913a"}, "capabilities": ["oob"]}}
    qemu-system: warning: nic xlnx.xps-ethernetlite.0 has no peer
    {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}}
    {"return": {}}
    {'execute': 'query-target'}
--> {"return": {"arch": "aarch64"}}

Perhaps you can fix this by reordering patches.  If you can't,
deficiencies like this one need a prominent mention in the commit
message.