From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43CB331203; Sat, 25 Jul 2026 10:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784974004; cv=none; b=CgYJmcN9BqhCy9pklK+y76hWaOSz4kNn/0orz6jLnRu4YdJX5edZjwF3sDDr5nXlCB3EvyM3GZympjgtKfdhBdcfN83L+eWNOM1FBL7V99zF3PqxJMBeEaaDR77eLOFkAy9grDb1wKBzOXSvyY/Bl2ZGkPawtquA4ayJr1315ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784974004; c=relaxed/simple; bh=XBEZNNMBpozb8Jvp0vJo6/Kw+9C2HHI4aF9GJUELexA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=sR6A8SJAcg/baeLZiJw2Y8e0BqyQUTDIfXgfWXHRdyzKP5mxtK/96/C0bd6/kMelBj8rgm07y+97dgVAg9NI6YlDMG0x7ITbimqY0ZmExufOsRfNe9uT6Exbg5enSPCuP8pIPpoqV2H3dTCagyGXk+vSPghfVDRSW1eJYXMrkb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z01H/2Pn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z01H/2Pn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 324771F000E9; Sat, 25 Jul 2026 10:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784974002; bh=OeZeYXXVdXRoU3CQiNKgt0hhBi4QmRAA6beAvcRVwVw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Z01H/2PnnNt6xZZgPO7Vl537h57sxQzAnfhZOsJS3aoy7f34C5RrOel3MHn2syvxt Ku5qPP4dKOwqoeZ18ooilmxe/KM6+gEgcpRteFyJRMPpimTLcWe3oCFScNMYIHMgXG S0mntHk/a6CfH+ICy+jpVhDnQ1GS594EmWBKT3ZuDR1JMjhf/d1aZW6Y0OdDS3/A+M 8CWDW/K8U1Z6tKJWTNSgm1JIEmn7bxAFw81n0iBBGcFKoNIIdI1ahn8ZOQ+nm02Mj8 ohAZUDqz8V3lu3/6npBGLojLrhZzVw6hSVs2GSzrGIFv0c0WBNJXaKcw4g5FPdCcrk cXI6zORjXvanw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wnZHE-00000008jCl-0wUe; Sat, 25 Jul 2026 10:06:40 +0000 Date: Sat, 25 Jul 2026 11:08:03 +0100 Message-ID: <8733x7qt4s.wl-maz@kernel.org> From: Marc Zyngier To: "Sascha Bischoff" ,sashiko-reviews@lists.linux.dev Cc: "Oliver Upton" , kvm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 03/48] irqchip/gic-v5: Set up gic_kvm_info on ACPI hosts In-Reply-To: <20260724111920.6F63C1F00A3F@smtp.kernel.org> References: <20260724104819.1296803-1-sascha.bischoff@arm.com> <20260724104819.1296803-4-sascha.bischoff@arm.com> <20260724111920.6F63C1F00A3F@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: Sascha.Bischoff@arm.com, sashiko-reviews@lists.linux.dev, oupton@kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 24 Jul 2026 12:19:20 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [High] Failed ACPI GSI registration for maintenance IRQ due to missing GICv5 hardware IRQ type encoding. > -- [...] > [Severity: High] > Does this fail to register the maintenance IRQ? > > acpi_register_gsi() passes the raw maint_irq directly into fwspec.param[0]. > However, the GICv5 PPI domain select function expects the hardware IRQ type to > be encoded in the upper bits: > > drivers/irqchip/irq-gic-v5.c:gicv5_irq_ppi_domain_select() { > ... > if (is_fwnode_irqchip(fwspec->fwnode)) > hwirq_type = FIELD_GET(GICV5_HWIRQ_TYPE, fwspec->param[0]); > > if (hwirq_type != GICV5_HWIRQ_TYPE_PPI) > return 0; > ... > } > > Because the raw MADT value doesn't have the GICV5_HWIRQ_TYPE_PPI bits set, the > mapping will be rejected. Should the GSI be encoded with the PPI type before > calling acpi_register_gsi()? Where is this coming from? I can't even find any public documentation for ACPI GICv5 support... Sascha? M. -- Jazz isn't dead. It just smells funny.