From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFFFA34107D; Thu, 2 Jul 2026 17:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783013982; cv=none; b=LX94h/gbZcf/SB6SoVBDslV71wQwCHxw8QHHF8k94zHd+5XieUWGYUBSkuvdCw251W9LTFjccUhweNsfjEoDiVPD3D/9LZdWloMeECN3MrtlKH1QFpJZ50ibq4HHMTB5uG9hNeK0gYthwrM6W88I6VQMP2txJ5irQvYbvajas0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783013982; c=relaxed/simple; bh=6N4Bg2b+t+GrNSxoSFhr4+LgUE7IVDBhDXPK5KLLMH8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=KoNY8a9omM3lIbjFXMNRR17rytNKcmgdm1cpMR/RA3roSsBeP8dvus13hT68hFOeulLUWTtOsKCdSgTKbiOdSAezwb4hRGUZY0agVAUm2g4UWGGc+wvbB9skKEIu1nJ0U48Gnr/VGFzVCL9g2hPwh34fnF82shbdGdzZKHymNNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GCbLnA/q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GCbLnA/q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 533AD1F000E9; Thu, 2 Jul 2026 17:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783013981; bh=7p6mwMxIeKEOLzjG5YeSK0tG82ZYp+L69Hc1Bm6FBFA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=GCbLnA/q1ritVqINJF+YEyPX/TKqQiACrIRjJfvGcVhIkKeOpqAS29vL946EByl/h I3+ie2VO8aYWJVJT5pzDVGjV3BxlkLJCawDszzQSL4xxWc5WGhXZ8JwLmwxy8lCJ/0 PvkLdjy/atAXNb6BlLXBIPqe6yC0yv9g1SZGtBAYgsrsuVVDjKGJK/nGVAxuUMMcVo AO6FQyTsOTON8JTKhu14Xzq+Z0S3kX6cTykPiwUbFGY3+3heZLPLvPrNvn+xsYRX+j jOszkEUIrg6unrWXHDa+eQ74VkvGTCmaNfnVurO7ynwJyHcPcIb4ZsyK2477gpJQ07 pOW3nK1+TAadQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wfLNz-00000000rEr-0DmQ; Thu, 02 Jul 2026 17:39:39 +0000 Date: Thu, 02 Jul 2026 18:41:27 +0100 Message-ID: <8733y18f20.wl-maz@kernel.org> From: Marc Zyngier To: sashiko-reviews@lists.linux.dev Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, "Oliver Upton" Subject: Re: [PATCH 01/28] arm64: sysreg: Emit RESx/UNKN values for Mapping definitions In-Reply-To: <20260702161927.B3C9F1F000E9@smtp.kernel.org> References: <20260702160248.1377250-1-maz@kernel.org> <20260702160248.1377250-2-maz@kernel.org> <20260702161927.B3C9F1F000E9@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashiko-reviews@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, oupton@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 02 Jul 2026 17:19:27 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] Invalid `_RESx` macros generated for `Mapping` aliases when the target uses `Fields`. > -- > > commit ba830a7cd4d5bdb5ba927754ed4d1c4e3a0b4f1c > Author: Marc Zyngier > > arm64: sysreg: Emit RESx/UNKN values for Mapping definitions > > The sysreg script uses the Mapping qualifier to indicate an encoding is a > mapping to a particular register, but macro generation for RESx classes was > previously skipped. This patch relaxes that rule to emit RESx and UNKN > values for Mapping qualifiers. > > > diff --git a/arch/arm64/tools/gen-sysreg.awk b/arch/arm64/tools/gen-sysreg.awk > > index 86860ab672dc7..d7f7ceb768fe5 100755 > > --- a/arch/arm64/tools/gen-sysreg.awk > > +++ b/arch/arm64/tools/gen-sysreg.awk > > [ ... ] > > > @@ -239,9 +239,15 @@ $1 == "EndSysreg" && block_current() == "Sysreg" { > > print "" > > > > next_bit = -1 > > - res0 = null > > - res1 = null > > - unkn = null > > + if ($1 == "Mapping") { > > + res0 = $2 "_RES0" > > + res1 = $2 "_RES1" > > + unkn = $2 "_UNKN" > > [Severity: Low] > Does this logic generate invalid macros if the target register uses the > "Fields" directive? Interesting point. This indeed breaks for a Mapping->Fields indirection. We don't have anything of this shape just yet, but it shouldn't hurt to generate the RESx/UNKN symbols for those as well. M. -- Jazz isn't dead. It just smells funny.