From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731FDC04AB4 for ; Fri, 17 May 2019 09:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4656820833 for ; Fri, 17 May 2019 09:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728852AbfEQJlP (ORCPT ); Fri, 17 May 2019 05:41:15 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36974 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbfEQJlO (ORCPT ); Fri, 17 May 2019 05:41:14 -0400 Received: by mail-wm1-f65.google.com with SMTP id 7so6097432wmo.2 for ; Fri, 17 May 2019 02:41:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=KxRunkTcWCXBXkqMmtp06kfjOty1pFHCahqZCzEUiJM=; b=WuWgmrZ35GNYYT1rU6RAoeqm0HqcWUEld6TRnfGl1uepTVK1DTuvAmjELybaCf9uJE 2vHm51mx9hB1vP4A3p9VnEClcqP92nSy49LHF11wfBVM9+NdG3Mwn5TYU1iO5UVdayde OYkTgcmKlQZYnLzfXkAnW0I27u1y+STjhqtbb4hBFQLdqFUhWegz3Ibgbe64bsomne4/ l/UEsE7vvpTWreJQuKgTUtKbcQzuYfLydvM3qAfg+majChSUbULfEO+s2KrLjs3SZdKK nI4ZFQm0Abj4zOXbVHSiPpRUqHW775Enicozq0M9swc7qm8PRu3+VkqaA/4SK2h4oJq8 lVfQ== X-Gm-Message-State: APjAAAViH48tel/ef2CxMuWexc6tnFNLcUU6rV5jvP/UARKGkGqG5z5u LhdgQv+BD6NIV8P61Z0WL/gLug== X-Google-Smtp-Source: APXvYqynKo0ZK83iexNrTTI233jg0pcjdFXYNk3oowX/WJJeDSY4aa0A3Lf2hs9mlXOehdBNipV1xQ== X-Received: by 2002:a1c:f616:: with SMTP id w22mr29244537wmc.28.1558086072451; Fri, 17 May 2019 02:41:12 -0700 (PDT) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 17sm10116301wrk.91.2019.05.17.02.41.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 02:41:11 -0700 (PDT) From: Vitaly Kuznetsov To: Peter Xu , Thomas Huth Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, Shuah Khan , Andrew Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] KVM: selftests: Compile code with warnings enabled In-Reply-To: <20190517093000.GO16681@xz-x1> References: <20190517090445.4502-1-thuth@redhat.com> <20190517093000.GO16681@xz-x1> Date: Fri, 17 May 2019 11:41:11 +0200 Message-ID: <8736ldquyw.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Peter Xu writes: > On Fri, May 17, 2019 at 11:04:45AM +0200, Thomas Huth wrote: >> So far the KVM selftests are compiled without any compiler warnings >> enabled. That's quite bad, since we miss a lot of possible bugs this >> way. Let's enable at least "-Wall" and some other useful warning flags >> now, and fix at least the trivial problems in the code (like unused >> variables). >> >> Signed-off-by: Thomas Huth >> --- >> v2: >> - Rebased to kvm/queue >> - Fix warnings in state_test.c and evmcs_test.c, too > > I still see these warnings (probably because the hyperv_cpuid.c is a > new test): > > In file included from x86_64/hyperv_cpuid.c:18: > x86_64/hyperv_cpuid.c: In function ‘test_hv_cpuid’: > x86_64/hyperv_cpuid.c:61:33: warning: suggest parentheses around comparison in operand of ‘==’ [-Wparentheses] > TEST_ASSERT(entry->padding[0] == entry->padding[1] > ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > include/test_util.h:32:15: note: in definition of macro ‘TEST_ASSERT’ > test_assert((e), #e, __FILE__, __LINE__, fmt, ##__VA_ARGS__) > ^ > x86_64/hyperv_cpuid.c:62:8: warning: suggest parentheses around comparison in operand of ‘==’ [-Wparentheses] > TEST_ASSERT(entry->padding[0] == entry->padding[1] > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > == entry->padding[2] == 0, > ^~~~~~~~~~~~~~~~~~~~ > include/test_util.h:32:15: note: in definition of macro ‘TEST_ASSERT’ > test_assert((e), #e, __FILE__, __LINE__, fmt, ##__VA_ARGS__) There's a fix from Dan Carpenter on the list: https://marc.info/?l=kernel-janitors&m=155783012012532&w=2 > ^ > x86_64/hyperv_cpuid.c: In function ‘kvm_get_supported_hv_cpuid’: > x86_64/hyperv_cpuid.c:93:6: warning: unused variable ‘ret’ [-Wunused-variable] > int ret; > ^~~ > > The first two seem to be real bugs in the test code, and the 3rd one > might need a cleanup too. -- Vitaly