From: "Alex Bennée" <alex.bennee@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, pbonzini@redhat.com,
kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test
Date: Fri, 11 Nov 2016 10:00:07 +0000 [thread overview]
Message-ID: <8737iy8hg8.fsf@linaro.org> (raw)
In-Reply-To: <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com>
Andre Przywara <andre.przywara@arm.com> writes:
> Hi,
>
> On 10/11/16 19:53, Alex Bennée wrote:
>
> ....
>> So I was re-basing my kvm-unit-tests against your GIC rework and found
>> myself copy and pasting a bunch of this into my tests that fire IRQs.
>
> So I take it you are working on (or already have) code to test SPIs,
> probably via GICD_ISPENDR?
> Just asking because I was thinking about going there and thus could save
> my time if you are on it already...
In my case I wanted to trigger SPIs to exercise my TCG tests for MTTCG:
https://github.com/stsquad/kvm-unit-tests/blob/mttcg/current-tests-v6/arm/tcg-test.c#L113
>> That makes me think the abstraction should be in the library code so
>> other tests can fiddle with sending IRQs.
>
> ...because I was wondering the same.
To answer Andrew's question from the other post I would be happy with a
common:
gic_enable
gic_send_spi(cpu, irq)
gic_irq_ack() which returns the iar.
>
> Cheers,
> Andre.
--
Alex Bennée
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2016-11-11 10:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:21 [kvm-unit-tests PATCH v5 00/11] arm/arm64: add gic framework Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 01/11] lib: xstr: allow multiple args Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 03/11] arm/arm64: smp: support more than 8 cpus Andrew Jones
2016-11-11 15:27 ` Andre Przywara
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 04/11] arm/arm64: add some delay routines Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 05/11] arm/arm64: irq enable/disable Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 06/11] arm/arm64: add initial gicv2 support Andrew Jones
2016-11-11 14:52 ` Alex Bennée
2016-11-11 15:17 ` Andre Przywara
2016-11-11 15:30 ` [Qemu-devel] " Andrew Jones
2016-11-11 15:24 ` Andrew Jones
2016-11-11 15:34 ` Andre Przywara
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 07/11] arm/arm64: gicv2: add an IPI test Andrew Jones
2016-11-11 11:13 ` Andre Przywara
2016-11-11 13:13 ` [Qemu-devel] " Andrew Jones
2016-11-14 14:12 ` Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 08/11] libcflat: add IS_ALIGNED() macro, and page sizes Andrew Jones
2016-11-11 15:02 ` Alex Bennée
2016-11-11 15:35 ` Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 09/11] arm/arm64: add initial gicv3 support Andrew Jones
2016-11-11 15:35 ` Alex Bennée
2016-11-11 16:31 ` Andre Przywara
2016-11-14 15:17 ` [Qemu-devel] " Andrew Jones
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test Andrew Jones
2016-11-10 19:53 ` Alex Bennée
2016-11-10 20:37 ` [Qemu-devel] " Andrew Jones
2016-11-11 10:02 ` Alex Bennée
2016-11-11 13:54 ` Andrew Jones
2016-11-11 14:53 ` Alex Bennée
2016-11-11 15:20 ` Andre Przywara
2016-11-11 9:21 ` Andre Przywara
2016-11-11 10:00 ` Alex Bennée [this message]
2016-11-10 17:21 ` [kvm-unit-tests PATCH v5 11/11] arm/arm64: gic: don't just use zero Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737iy8hg8.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).