From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [RFC][PATCH] Remove duplicate setting of the B field in tlbie Date: Wed, 14 Sep 2016 10:25:09 +0530 Message-ID: <8737l3jd1u.fsf@linux.vnet.ibm.com> References: <4bbac7fd-ed99-a5c4-1bda-94345b88f18c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Balbir Singh , Paul Mackerras Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35718 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751168AbcINEzQ (ORCPT ); Wed, 14 Sep 2016 00:55:16 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8E4rSj9022659 for ; Wed, 14 Sep 2016 00:55:15 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 25ewq8x6r9-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 14 Sep 2016 00:55:15 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Sep 2016 00:55:15 -0400 In-Reply-To: <4bbac7fd-ed99-a5c4-1bda-94345b88f18c@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Balbir Singh writes: > Remove duplicate setting of the the "B" field when doing a tlbie(l). > In compute_tlbie_rb(), the "B" field is set again just before > returning the rb value to be used for tlbie(l). > > Signed-off-by: Balbir Singh > --- > Quickly boot tested a VM with these changes in kvm with 64k > as the page size for the guest. > > arch/powerpc/include/asm/kvm_book3s_64.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h > index 88d17b4..63b6900 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_64.h > +++ b/arch/powerpc/include/asm/kvm_book3s_64.h > @@ -159,7 +159,6 @@ static inline unsigned long compute_tlbie_rb(unsigned long v, unsigned long r, > /* This covers 14..54 bits of va*/ > rb = (v & ~0x7fUL) << 16; /* AVA field */ > > - rb |= (v >> HPTE_V_SSIZE_SHIFT) << 8; /* B field */ > /* > * AVA in v had cleared lower 23 bits. We need to derive > * that from pteg index Can we keep this and remove the other. This is much easier to follow than rb |= (v >> 54) & 0x300; /* B field */ -aneesh