From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] x86: Use "-cpu host" for PCID tests
Date: Wed, 05 Feb 2020 12:37:11 +0100 [thread overview]
Message-ID: <874kw5mfiw.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20200204194809.2077-1-sean.j.christopherson@intel.com>
Sean Christopherson <sean.j.christopherson@intel.com> writes:
> Use the host CPU model for the PCID tests to allow testing the various
> combinations of PCID and INVPCID enabled/disabled without having to
> manually change the kvm-unit-tests command line. I.e. give users the
> option of changing the command line *OR* running on a (virtual) CPU
> with or without PCID and/or INVPCID.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> x86/unittests.cfg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index aae1523..25f4535 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -228,7 +228,7 @@ extra_params = --append "10000000 `date +%s`"
>
> [pcid]
> file = pcid.flat
> -extra_params = -cpu qemu64,+pcid
> +extra_params = -cpu host
> arch = x86_64
>
> [rdpru]
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Actually, is there any reason for *not* using '-cpu host' in any of the
tests?
--
Vitaly
next prev parent reply other threads:[~2020-02-05 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 19:48 [kvm-unit-tests PATCH] x86: Use "-cpu host" for PCID tests Sean Christopherson
2020-02-05 11:37 ` Vitaly Kuznetsov [this message]
2020-02-05 14:36 ` Sean Christopherson
2020-02-05 15:26 ` Paolo Bonzini
2020-02-05 15:44 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kw5mfiw.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox