From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: RE: [PATCH v2] x86/hyper-v: Mark TLFS structures packed
Date: Mon, 03 Dec 2018 14:45:28 +0100
Message-ID: <874lbuyb9j.fsf@vitty.brq.redhat.com>
References: <20181130125422.21494-1-vkuznets@redhat.com> <CY4PR21MB0773D5DFA13BFA0701771F5ED7AE0@CY4PR21MB0773.namprd21.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Roman Kagan <rkagan@virtuozzo.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "x86\@kernel.org" <x86@kernel.org>,
        Nadav Amit <nadav.amit@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>
To: Michael Kelley <mikelley@microsoft.com>,
        "kvm\@vger.kernel.org" <kvm@vger.kernel.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CY4PR21MB0773D5DFA13BFA0701771F5ED7AE0@CY4PR21MB0773.namprd21.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Michael Kelley <mikelley@microsoft.com> writes:

> From: Vitaly Kuznetsov <vkuznets@redhat.com>  Sent: Friday, November 30, 2018 4:54 AM
>> 
>> @@ -466,7 +466,7 @@ union hv_message_flags {
>>  	struct {
>>  		__u8 msg_pending:1;
>>  		__u8 reserved:7;
>> -	};
>> +	} __packed;
>>  };
>> 
>>  /* Define port identifier type. */
>
> I think __packed is also needed in the definition
> of struct u defined within union hv_port_id.  That
> struct has bit fields, so shouldn't it be done just like
> union hv_message_flags above?
>

True, missed it, thanks! Will send v3 out shortly.

-- 
Vitaly