From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D098C71153 for ; Mon, 28 Aug 2023 17:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbjH1RQl (ORCPT ); Mon, 28 Aug 2023 13:16:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231401AbjH1RQa (ORCPT ); Mon, 28 Aug 2023 13:16:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EAEBA7 for ; Mon, 28 Aug 2023 10:16:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6BE861827 for ; Mon, 28 Aug 2023 17:16:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2227CC433C9; Mon, 28 Aug 2023 17:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693242987; bh=2YWgIPTvFSXYDXTv/2vynQLG0W/29Q6hHvhgN33lLx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LnQpu0NyCeEtEWHeUGUR45mQPBH1xNamUuyXvFFOAKPmYI1is6Na1V3hyCbdz2mQV riePyqakGrOx6WBSv5gn1NPn28/bjpsSMDSuZKsRlLv8Q1KYKEqGZ/p5JYxI3bq/a4 MrYDWtaRvBBsBGagVHm1FCHg9SMGjTzdqj5WzYIO/4RhD8gQ94y8vqB6EE2E2omyvR MTtOzZjs6fjqx8qVhawd4c0ApWtI0CQH0NlLT5lCRcDpyy83NW8/CkMFAaUa2kDFvp PWdu/dzfRbTB/DDs7sZMfHaadiO8xIZWWc2wgXwe9BViLcJnXkjLNof/ZdNJIuk+dP NLnDIzjSu+6Qw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qafqi-008nMW-Co; Mon, 28 Aug 2023 18:16:24 +0100 Date: Mon, 28 Aug 2023 18:16:25 +0100 Message-ID: <875y4zozo6.wl-maz@kernel.org> From: Marc Zyngier To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Vincent Donnefort , Marek Szyprowski Subject: Re: [PATCH] KVM: arm64: Properly return allocated EL2 VA from hyp_alloc_private_va_range() In-Reply-To: References: <20230828153121.4179627-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: philmd@linaro.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, vdonnefort@google.com, m.szyprowski@samsung.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Philippe, On Mon, 28 Aug 2023 18:00:54 +0100, Philippe Mathieu-Daud=C3=A9 wrote: >=20 > Hi Marc, >=20 > On 28/8/23 17:31, Marc Zyngier wrote: > > Marek reports that his RPi4 spits out a warning at boot time, > > right at the point where the GICv2 virtual CPU interface gets > > mapped. > >=20 > > Upon investigation, it seems that we never return the allocated > > VA and use whatever was on the stack at this point. Yes, this > > is good stuff, and Marek was pretty lucky that he ended-up with > > a VA that intersected with something that was already mapped. > >=20 > > On my setup, this random value is plausible enough for the mapping > > to take place. Who knows what happens... > >=20 > > Cc: Vincent Donnefort > > Fixes: f156a7d13fc3 ("KVM: arm64: Remove size-order align in the nVHE h= yp private VA range") >=20 > I don't see your kvmarm-6.6 merged by Paolo, is it too late to squash > and send a new PR? In general, I keep the commits that are in -next stable (no squashing, no rebasing), and only the merge commits that drag these commits onto -next are throw-away (this allows me to rebuild the whole branch without changing any of the commit SHAs). So no, I won't send a new PR right now. However, I'll stick the patch in -next and will aim to send Paolo another PR later this week or early next week. > Anyhow: >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Thanks! M. --=20 Without deviation from the norm, progress is not possible.