From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56106C43334 for ; Sun, 24 Jul 2022 09:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233202AbiGXJk0 (ORCPT ); Sun, 24 Jul 2022 05:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbiGXJkY (ORCPT ); Sun, 24 Jul 2022 05:40:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC725DF64 for ; Sun, 24 Jul 2022 02:40:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 72B0860C5E for ; Sun, 24 Jul 2022 09:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD645C3411E; Sun, 24 Jul 2022 09:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658655622; bh=ai38sc1PReEG6rA+X8KF493BzH1wNrYlLI9G+eK3cKw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YrAQh2sr9uarRwlz3lBupMMxtqpEeDcc3kIYFpqBXTX32JMJKOkt4LBHOzDjcINAF QxI2/IpJQwQoeP2TbaCnJJgd6734EP7L4rgUJAkb4KqsFqZWefrOIjgNCuheRFXnkw JlQLBGT2E+tyd06vbqiWCKzgtIXTgcoiKpPIaq5egqDjNd/YtpmKax9HT7ASx2LQe3 ihK6qtWfIiXZtGPOEF/Ciz9fF9dVeiJsBi6SQSryGP2Ra7a+zeHa0622qXLncohmKk j8rkLAdIROsmgZfUKrwyoSinl82wbbX55X71vFjxKUymSRWa4KWhiq9pLSRW279aNP BLAuI/MSB9GXA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oFY60-009fGT-MZ; Sun, 24 Jul 2022 10:40:20 +0100 Date: Sun, 24 Jul 2022 10:40:20 +0100 Message-ID: <875yjmdf23.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Jones Cc: Ricardo Koller , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [kvm-unit-tests PATCH 3/3] arm: pmu: Remove checks for !overflow in chained counters tests In-Reply-To: <20220723075955.ipoekdpzkqticadt@kamzik> References: <20220718154910.3923412-1-ricarkol@google.com> <20220718154910.3923412-4-ricarkol@google.com> <87edyhz68i.wl-maz@kernel.org> <875yjsyv67.wl-maz@kernel.org> <871quezill.wl-maz@kernel.org> <20220723075955.ipoekdpzkqticadt@kamzik> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: andrew.jones@linux.dev, ricarkol@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, 23 Jul 2022 08:59:55 +0100, Andrew Jones wrote: > > On Fri, Jul 22, 2022 at 02:53:20PM -0700, Ricardo Koller wrote: > > > > Which brings me to what to do with this test. Should it be fixed for > > bare-metal by ignoring the PMOVSSET check? or should it actually check > > for PMOVSSET=1 and fail on KVM until KVM gets fixed? > > > > Hi Ricardo, > > Please write the test per the spec. Failures pointed out in kvm-unit-tests > are great, when the tests are written correctly, since it means it's > doing its job :-) Agreed. This is a bug, and bugs are to be fixed. The fact that it will flare up and annoy people is a good incentive to fix the kernel! Thanks, M. -- Without deviation from the norm, progress is not possible.