Re: [PATCH 3/4] KVM: selftests: Update aarch64 get-reg-list blessed list

[Marc Zyngier <maz@kernel.org>]

On Thu, 29 Oct 2020 20:17:02 +0000,
Andrew Jones <drjones@redhat.com> wrote:
> 
> The new registers come from the following commits:
> 
> commit 99adb567632b ("KVM: arm/arm64: Add save/restore support for
> firmware workaround state")
> 
> commit c773ae2b3476 ("KVM: arm64: Save/Restore guest DISR_EL1")
> 
> commit 03fdfb269009 ("KVM: arm64: Don't write junk to sysregs on reset")
> 
> The last commit, which adds ARM64_SYS_REG(3, 3, 9, 12, 0) (PMCR_EL0),
> and was committed for v5.3, doesn't indicate in its commit message that
> enumerating it for save/restore was the plan, so doing so may have
> been by accident.

It definitely was.

> It's a good idea anyway, though, since the other PMU registers have
> been enumerated since v4.10.

Quite. The state of the PMU is pretty much unknown on restore until then.

> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  tools/testing/selftests/kvm/aarch64/get-reg-list.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> index 3aeb3de780a1..3ff097f6886e 100644
> --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> @@ -352,7 +352,8 @@ int main(int ac, char **av)
>  }
>  
>  /*
> - * The current blessed list comes from kernel version v4.15 with --core-reg-fixup
> + * The current blessed list was primed with the output of kernel version
> + * v4.15 with --core-reg-fixup and then later updated with new registers.

Maybe have a reference to the last kernel version this was checked
against? Either here or in the commit message?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.