From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C14C433E1 for ; Tue, 25 Aug 2020 13:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2485D2076C for ; Tue, 25 Aug 2020 13:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Hc83hbjR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgHYNt3 (ORCPT ); Tue, 25 Aug 2020 09:49:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:2124 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgHYNt3 (ORCPT ); Tue, 25 Aug 2020 09:49:29 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07PDVwt4080456 for ; Tue, 25 Aug 2020 09:49:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=BKHuCQ+EnJ4ITV61tsX3y5kt3cp4aCHcqle7JQTyaXw=; b=Hc83hbjR+kch2dDKwvF5A9vU4U4fk78SefLaDGapy3ujIXNZ97Gbi2z/vie5FWTJzzWT isKK5cGqpoqpM+9RfQ/Zaxlzezd8iTg2suzHh5x+pW/4dsLJKWijYmYD2H8O0et6wPlG Klpun9GmwGnBKkmg9lFSEBuEbe7uijHArJGpIcgUSLQ4ldwsXvwPTXnTgAzbM7z71oa6 NDrX1B5Q1bqZKTHQlGiA3TrKYGRGxsL09BnXJVxGEJk71mGzau2fJkDhoLs25NA9iMvG oKH87Ed4HOpCRsVy/C+5uu/yWJfEXWkm3/W7GDVQCwEjw+tgVDUh/4pKMHb/ehVjQ6EG yA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3353f50w15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Aug 2020 09:49:28 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07PDW0JT080673 for ; Tue, 25 Aug 2020 09:49:28 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3353f50w05-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 09:49:27 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07PDfvOO015377; Tue, 25 Aug 2020 13:49:25 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma03ams.nl.ibm.com with ESMTP id 332ujkugfa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 13:49:25 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07PDnNME19071416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Aug 2020 13:49:23 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35C7042047; Tue, 25 Aug 2020 13:49:23 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 058844204B; Tue, 25 Aug 2020 13:49:23 +0000 (GMT) Received: from marcibm (unknown [9.145.56.167]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 25 Aug 2020 13:49:22 +0000 (GMT) From: Marc Hartmayer To: Cornelia Huck Cc: kvm@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH v2 2/2] Use same test names in the default and the TAP13 output format In-Reply-To: <20200825141312.07f52184.cohuck@redhat.com> References: <20200825102036.17232-1-mhartmay@linux.ibm.com> <20200825102036.17232-3-mhartmay@linux.ibm.com> <20200825141312.07f52184.cohuck@redhat.com> Date: Tue, 25 Aug 2020 15:49:22 +0200 Message-ID: <875z96kf8d.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-25_04:2020-08-25,2020-08-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 suspectscore=2 bulkscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008250098 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Aug 25, 2020 at 02:13 PM +0200, Cornelia Huck w= rote: > On Tue, 25 Aug 2020 12:20:36 +0200 > Marc Hartmayer wrote: > >> Use the same test names in the TAP13 output as in the default output >> format. This makes the output more consistent. To achieve this, we >> need to pass the test name as an argument to the function >> `process_test_output`. >>=20 >> Before this change: >> $ ./run_tests.sh >> PASS selftest-setup (14 tests) >> ... >>=20 >> vs. >>=20 >> $ ./run_tests.sh -t >> TAP version 13 >> ok 1 - selftest: true >> ok 2 - selftest: argc =3D=3D 3 >> ... >>=20 >> After this change: >> $ ./run_tests.sh >> PASS selftest-setup (14 tests) >> ... >>=20 >> vs. >>=20 >> $ ./run_tests.sh -t >> TAP version 13 >> ok 1 - selftest-setup: selftest: true >> ok 2 - selftest-setup: selftest: argc =3D=3D 3 >> ... >>=20 >> While at it, introduce a local variable `kernel` in >> `RUNTIME_log_stdout` since this makes the function easier to read. >>=20 >> Signed-off-by: Marc Hartmayer >> --- >> run_tests.sh | 15 +++++++++------ >> scripts/runtime.bash | 6 +++--- >> 2 files changed, 12 insertions(+), 9 deletions(-) > > Reviewed-by: Cornelia Huck > Thanks. --=20 Kind regards / Beste Gr=C3=BC=C3=9Fe Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen=20 Gesch=C3=A4ftsf=C3=BChrung: Dirk Wittkopp Sitz der Gesellschaft: B=C3=B6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294