From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0939C636D4 for ; Mon, 6 Feb 2023 16:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbjBFQRB (ORCPT ); Mon, 6 Feb 2023 11:17:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230411AbjBFQRA (ORCPT ); Mon, 6 Feb 2023 11:17:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5004976E for ; Mon, 6 Feb 2023 08:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675700156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1YxdtXAKHSW2xa0lWBV1M5rrSQV9boHSWRJ7x97GV8=; b=Jx2if8YvsKi6MHXzVjlj8ZLOgbXZ050nzKjprfHqEKSwFCbubnHRc/mj+YtS/emKKo8ISV +sK5bxc9Nun56gowU4GfhCq2EZFAzGZ323u1gugKASSx8ApimeSNO4HPV5CiyFy65OGbn8 Wkp9jP3jXs3m1MBTVQuQP9B1pPBcgf4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-kSF7DlEePbyFJS4Mn4WExA-1; Mon, 06 Feb 2023 11:15:52 -0500 X-MC-Unique: kSF7DlEePbyFJS4Mn4WExA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 851C685A588; Mon, 6 Feb 2023 16:15:51 +0000 (UTC) Received: from localhost (dhcp-192-239.str.redhat.com [10.33.192.239]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 253B140398A0; Mon, 6 Feb 2023 16:15:51 +0000 (UTC) From: Cornelia Huck To: Eric Auger , Richard Henderson , Peter Maydell , Thomas Huth , Laurent Vivier Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, "Dr. David Alan Gilbert" , Juan Quintela , Gavin Shan , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 2/3] arm/kvm: add support for MTE In-Reply-To: <071ec3a6-cb4b-0dac-87fd-f3c3d00b5e83@redhat.com> Organization: Red Hat GmbH References: <20230203134433.31513-1-cohuck@redhat.com> <20230203134433.31513-3-cohuck@redhat.com> <071ec3a6-cb4b-0dac-87fd-f3c3d00b5e83@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 06 Feb 2023 17:15:49 +0100 Message-ID: <877cwun51m.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Feb 06 2023, Eric Auger wrote: > Hi, > > On 2/3/23 21:40, Richard Henderson wrote: >> On 2/3/23 03:44, Cornelia Huck wrote: >>> +static void aarch64_cpu_get_mte(Object *obj, Visitor *v, const char >>> *name, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *opaque, Error **errp) >>> +{ >>> +=C2=A0=C2=A0=C2=A0 ARMCPU *cpu =3D ARM_CPU(obj); >>> +=C2=A0=C2=A0=C2=A0 OnOffAuto mte =3D cpu->prop_mte; >>> + >>> +=C2=A0=C2=A0=C2=A0 visit_type_OnOffAuto(v, name, &mte, errp); >>> +} >>=20 >> You don't need to copy to a local variable here. >>=20 >>> + >>> +static void aarch64_cpu_set_mte(Object *obj, Visitor *v, const char >>> *name, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *opaque, Error **errp) >>> +{ >>> +=C2=A0=C2=A0=C2=A0 ARMCPU *cpu =3D ARM_CPU(obj); >>> + >>> +=C2=A0=C2=A0=C2=A0 visit_type_OnOffAuto(v, name, &cpu->prop_mte, errp); >>> +} >>=20 >> ... which makes get and set functions identical. >> No need for both. > This looks like a common pattern though. virt_get_acpi/set_acpi in > virt.c or pc_machine_get_vmport/set_vmport in i386/pc.c and many other > places (microvm ...). Do those other callers also need some simplificatio= ns? Indeed, I'm pretty sure that I copied + adapted it from somewhere :) Should we clean up all instances in one go instead? (Probably on top of this series, in order to minimize conflicts with other changes.)