From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: 黄乐 <huangle1@jd.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] KVM: x86: Fix uninitialized eoi_exit_bitmap usage in vcpu_load_eoi_exitmap()
Date: Mon, 15 Nov 2021 14:00:48 +0100 [thread overview]
Message-ID: <877dd9efpb.fsf@redhat.com> (raw)
In-Reply-To: <567b276444f841519e42c91f43f5acd7@jd.com>
黄乐 <huangle1@jd.com> writes:
>> 黄乐 <huangle1@jd.com> writes:
>>
>> > In vcpu_load_eoi_exitmap(), currently the eoi_exit_bitmap[4] array is
>> > initialized only when Hyper-V context is available, in other path it is
>> > just passed to kvm_x86_ops.load_eoi_exitmap() directly from on the stack,
>> > which would cause unexpected interrupt delivery/handling issues, e.g. an
>> > *old* linux kernel that relies on PIT to do clock calibration on KVM might
>> > randomly fail to boot.
>> >
>> > Fix it by passing ioapic_handled_vectors to load_eoi_exitmap() when Hyper-V
>> > context is not available.
>> >
>> > Signed-off-by: Huang Le <huangle1@jd.com>
>>
>> Fixes: f2bc14b69c38 ("KVM: x86: hyper-v: Prepare to meet unallocated Hyper-V context")
>> Cc: stable@vger.kernel.org
>
> Commit f2bc14b69c38 is not in stable tree I guess, it was merged in from 5.12,
> do we still need Cc this patch to stable maintainers?
>
There are multiple stable trees, one for each major release. Not all of
them are still supported but you don't need to care about it, 'Cc:
stable@vger.kernel.org' is just an indication for everyone who has
f2bc14b69c38 in his tree (5.12+) that there's a fix available.
--
Vitaly
prev parent reply other threads:[~2021-11-15 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:41 Re: [PATCH] KVM: x86: Fix uninitialized eoi_exit_bitmap usage in vcpu_load_eoi_exitmap() 黄乐
2021-11-15 13:00 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dd9efpb.fsf@redhat.com \
--to=vkuznets@redhat.com \
--cc=huangle1@jd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox