From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH] KVM: PPC: Use schedule instead of cond_resched Date: Tue, 10 Dec 2013 21:38:14 +0530 Message-ID: <877gbcsn81.fsf@linux.vnet.ibm.com> References: <1386685284-3862-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Ben Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, "kvm\@vger.kernel.org mailing list" To: Alexander Graf Return-path: Received: from e28smtp04.in.ibm.com ([122.248.162.4]:47524 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065Ab3LJQIZ (ORCPT ); Tue, 10 Dec 2013 11:08:25 -0500 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Dec 2013 21:38:23 +0530 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf writes: > On 10.12.2013, at 15:21, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" >> >> We already checked need_resched. So we can call schedule directly >> >> Signed-off-by: Aneesh Kumar K.V > > The real fix for the issue you're seeing is > > https://lkml.org/lkml/2013/11/28/241 True, I mentioned that in the thread https://lkml.org/lkml/2013/12/9/64 But do we need to do cond_resched after we checked for need_resched() ? -aneesh