From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/5] tools/kvm/9p: Don't follow symlink on server
Date: Sun, 19 Jun 2011 14:41:57 +0530
Message-ID: <877h8i18yq.fsf@linux.vnet.ibm.com>
References: <1308419348-31934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308419348-31934-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308423073.3766.6.camel@lappy> <87aade1jte.fsf@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, kvm@vger.kernel.org
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e38.co.us.ibm.com ([32.97.110.159]:49122 "EHLO
	e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752886Ab1FSJMK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 19 Jun 2011 05:12:10 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227])
	by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5J93hQf006032
	for <kvm@vger.kernel.org>; Sun, 19 Jun 2011 03:03:43 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p5J9C61H153058
	for <kvm@vger.kernel.org>; Sun, 19 Jun 2011 03:12:06 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5J3BcWP008679
	for <kvm@vger.kernel.org>; Sat, 18 Jun 2011 21:11:38 -0600
In-Reply-To: <87aade1jte.fsf@linux.vnet.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 19 Jun 2011 10:47:33 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> On Sat, 18 Jun 2011 14:51:13 -0400, Sasha Levin <levinsasha928@gmail.com> wrote:
> > On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote:
> > > Use lstat instead of stat
> > 
> > This patch should probably come after 9p2000.u support is added, since
> > now we transparently work 'through' symlinks (because legacy 9p2000
> > doesn't support them).
> > Once 9p2000.u support is added we could represent symlinks and then a
> > switch to lstat might be due.
> > 
> 
> Shouldn't we aim to support 9p2000.L directly rather than supporting all
> the three versions of protocol ? Linux guest have good support for
> 9p2000.L
> 
> Do you think the patch breaks any of the expectation of 9p2000 ?. It
> would be nice to get the correct file attributes when fetching
> attributes from the server, irrespective of whether client support symlink
> or not.

I sent Message-Id: <1308474599-9832-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
which add error handling to tools/kvm/9p. I guess we don't want server
to follow symlink outside export path, hence open with O_NOFOLLOW.

-aneesh