From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <agraf@csgraf.de>,
Mohamed Mediouni <mohamed@unpredictable.fr>,
Pedro Barbuda <pbarbuda@microsoft.com>,
qemu-arm@nongnu.org, kvm@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v7 7/8] target/arm: handle the WFE trap case
Date: Mon, 15 Jun 2026 11:56:11 +0100 [thread overview]
Message-ID: <878q8gjcms.fsf@draig.linaro.org> (raw)
In-Reply-To: <CAFEAcA8719Q=VCwOm790V6FPA8FyaFZEux=N-7PmOGaaq=O_sw@mail.gmail.com> (Peter Maydell's message of "Mon, 8 Jun 2026 16:53:25 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Fri, 29 May 2026 at 09:29, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Now WFE can actually suspend on A-profile we also need to handle when
>> its trapped. To do this we need to pass the instruction size so we can
>> deal with the is_16bit syndrome encoding.
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> Doesn't this need to go earlier in the patchset? Otherwise there's
> a point where WFE can go to sleep but doesn't honour the trap bit.
Hmm - the way I read the description was we would only trap if we were
going to sleep. Pre 6/8 we never sleep so we can't trap. I could merge
it with 6/8 but then that makes the patch even bigger.
>
> thanks
> -- PMM
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2026-06-15 10:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 8:29 [PATCH v7 0/8] target/arm: fully model WFxT instructions for A-profile Alex Bennée
2026-05-29 8:29 ` [PATCH v7 1/8] target/arm: fix WFET typo in syndrome Alex Bennée
2026-05-29 8:29 ` [PATCH v7 2/8] target/arm: teach arm_cpu_has_work about halting reasons Alex Bennée
2026-05-29 8:29 ` [PATCH v7 3/8] target/arm: redefine event stream fields Alex Bennée
2026-05-29 8:29 ` [PATCH v7 4/8] target/arm: ensure aarch64 DISAS_WFE will exit Alex Bennée
2026-05-29 8:29 ` [PATCH v7 5/8] target/arm: implements SEV/SEVL for all modes Alex Bennée
2026-06-08 15:52 ` Peter Maydell
2026-05-29 8:29 ` [PATCH v7 6/8] target/arm: enable event stream on WFE instructions Alex Bennée
2026-05-29 8:29 ` [PATCH v7 7/8] target/arm: handle the WFE trap case Alex Bennée
2026-06-08 15:53 ` Peter Maydell
2026-06-15 10:56 ` Alex Bennée [this message]
2026-06-15 11:01 ` Peter Maydell
2026-06-15 12:24 ` Alex Bennée
2026-05-29 8:29 ` [PATCH v7 8/8] target/arm: implement WFET Alex Bennée
2026-06-08 13:51 ` [PATCH v7 0/8] target/arm: fully model WFxT instructions for A-profile Peter Maydell
2026-06-08 15:54 ` Peter Maydell
2026-06-08 17:01 ` Alex Bennée
2026-06-12 17:18 ` Alex Bennée
2026-06-12 17:46 ` Peter Maydell
2026-06-12 18:50 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q8gjcms.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@csgraf.de \
--cc=kvm@vger.kernel.org \
--cc=mohamed@unpredictable.fr \
--cc=pbarbuda@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox