From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045A228A72E; Mon, 4 Aug 2025 18:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754331315; cv=none; b=dlGQgoGG0G0o/AA6qj8zcgfgtcSVGJXtluRSoIqLlcYP1EwcZ7CD62qBEu3QLs/qcoXXNYHbcSR3kyl8uVg3+0B+jslGaPZ0ezU//3DZuPisyekNTnBiPfF8LbDbXV94msz1/ypqDjNw+rNyH0kQOhfCCxRhD8gUNwxsDgWW1R8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754331315; c=relaxed/simple; bh=MfY9E64xozt0VwwpOKv5Ewr0IueeJxAJqTz6huTX3BE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=tOJtRSMlsZOIIydx/VzAji1FqZe6nHKSaNhYBhuB72VDuH/C5h5MUFm926qkU2TDHTTCM5/Kpvaz8thdt4ojDYye/wKO1gmAh3tDNSsGLKHb87biSdWjKd9U1vvMpZbGGEWG1ZvTXRnnsk+XSkf0SRD5YYl+iGDI0xOxxG6/4gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mc1diXhX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mc1diXhX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D167C4CEE7; Mon, 4 Aug 2025 18:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754331313; bh=MfY9E64xozt0VwwpOKv5Ewr0IueeJxAJqTz6huTX3BE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mc1diXhXsOE8shBsIj5noHn5zQra9hSnR09Q1Ha4yDsxt/QGHJpgY1Dn4XkfJrfCJ mTVl0ToZ4nGqN9mHbk/CYrxNEp3wIsyZ830Nf4eK/gJ2xJme1JuRLWpQYTx4iloUFK A0MzIg2yGrWIqswgv/RQi031Xsu0+Cb5ZW8mBbjTcufDU/O+Oef9CBlSwXb3E4Qpa7 2T19iD0Q+QQUk8YMsT/E98brehYiDsrako8IcgexM7h+I79ITiYanuTDB/4nDyiclk 74fehiMvy52mm9rSc1xjFUOV/t1JYAvg1pXmf5GNQg4V0gu6TESDjCjVuvXkgtvzZZ 02r3U6pcPyeGw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uiziJ-003tJw-Fg; Mon, 04 Aug 2025 19:15:11 +0100 Date: Mon, 04 Aug 2025 19:15:10 +0100 Message-ID: <878qjzt0lt.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: Andre Przywara , Will Deacon , Julien Thierry , kvm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH kvmtool v3 6/6] arm64: Generate HYP timer interrupt specifiers In-Reply-To: References: <20250729095745.3148294-1-andre.przywara@arm.com> <20250729095745.3148294-7-andre.przywara@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, andre.przywara@arm.com, will@kernel.org, julien.thierry.kdev@gmail.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 04 Aug 2025 15:47:55 +0100, Alexandru Elisei wrote: > > KVM doesn't allow FEAT_VHE and FEAT_E2H0 to coexist (in > nested.c::limit_nv_id_reg()), to force E2H to be RES0. Assuming my interpretion > is correct, shouldn't the check be: > > if (!kvm->cfg.arch.nested_virt || kvm->cfg.arch.e2h0) > nr--; > And yet KVM exposes that timer, irrespective of FEAT_VHE. Probably something that should be addressed. M. -- Jazz isn't dead. It just smells funny.