Re: [PATCH 11/20] accel: Rename 'hw/core/accel-cpu.h' -> 'accel/accel-cpu-target.h'

Richard Henderson
2025-01-26T20:39:38Z

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
> AccelCPUClass is for accelerator to initialize target specific
> features of a vCPU. Not really related to hardware emulation,
> rename "hw/core/accel-cpu.h" as "accel/accel-cpu-target.h"
> (using the explicit -target suffix).
>
> More importantly, target specific header often access the
> target specific definitions which are in each target/FOO/cpu.h
> header, usually included generically as "cpu.h" relative to
> target/FOO/. However, there is already a "cpu.h" in hw/core/
> which takes precedence. This change allows "accel-cpu-target.h"
> to include a target "cpu.h".
>
> Mechanical change doing:
>
> $ git mv include/hw/core/accel-cpu.h \
> include/accel/accel-cpu-target.h
> $ sed -i -e 's,hw/core/accel-cpu.h,accel/accel-cpu-target.h,' \
> $(git grep -l hw/core/accel-cpu.h)
>
> and renaming header guard 'ACCEL_CPU_TARGET_H'.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> MAINTAINERS | 2 +-
> include/{hw/core/accel-cpu.h => accel/accel-cpu-target.h} | 4 ++--
> accel/accel-target.c | 2 +-
> cpu-target.c | 2 +-
> target/i386/hvf/hvf-cpu.c | 2 +-
> target/i386/kvm/kvm-cpu.c | 2 +-
> target/i386/tcg/tcg-cpu.c | 2 +-
> target/ppc/kvm.c | 2 +-
> target/riscv/kvm/kvm-cpu.c | 2 +-
> target/riscv/tcg/tcg-cpu.c | 2 +-
> 10 files changed, 11 insertions(+), 11 deletions(-)
> rename include/{hw/core/accel-cpu.h => accel/accel-cpu-target.h} (95%)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~