Re: [PATCH 13/20] accel: Forward-declare AccelOpsClass in 'qemu/typedefs.h'

Richard Henderson
2025-01-26T20:42:17Z

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
> The heavily imported "system/cpus.h" header includes "accel-ops.h"
> to get AccelOpsClass type declaration. Reduce headers pressure by
> forward declaring it in "qemu/typedefs.h", where we already
> declare the AccelCPUState type.
>
> Reduce "system/cpus.h" inclusions by only including
> "system/accel-ops.h" when necessary.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> include/qemu/typedefs.h | 1 +
> include/system/accel-ops.h | 1 -
> include/system/cpus.h | 2 --
> accel/accel-system.c | 1 +
> accel/hvf/hvf-accel-ops.c | 1 +
> accel/kvm/kvm-accel-ops.c | 1 +
> accel/qtest/qtest.c | 1 +
> accel/tcg/cpu-exec-common.c | 1 -
> accel/tcg/cpu-exec.c | 1 -
> accel/tcg/monitor.c | 1 -
> accel/tcg/tcg-accel-ops.c | 1 +
> accel/tcg/translate-all.c | 1 -
> accel/xen/xen-all.c | 1 +
> cpu-common.c | 1 -
> cpu-target.c | 1 +
> gdbstub/system.c | 1 +
> system/cpus.c | 1 +
> target/i386/nvmm/nvmm-accel-ops.c | 1 +
> target/i386/whpx/whpx-accel-ops.c | 1 +
> 19 files changed, 12 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~