Re: [PATCH v8 00/10] x86/cpu: KVM: Clean up PAT and VMX macros

Sean Christopherson
2024-08-15T15:23:17Z

On Wed, Jun 05, 2024, Sean Christopherson wrote:
> The primary goal of this series is to clean up the VMX MSR macros and their
> usage in KVM.
>
> The first half of the series touches memtype code that (obviously) impacts
> areas well outside of KVM, in order to address several warts:
>
> (a) KVM is defining VMX specific macros for the architectural memtypes
> (b) the PAT and MTRR code define similar, yet different macros
> (c) that the PAT code not only has macros for the types (well, enums),
> it also has macros for encoding the entire PAT MSR that can be used
> by KVM.
>
> The memtype changes aren't strictly required for the KVM-focused changes in
> the second half of the series, but splitting this into two series would
> generating a number of conflicts that would be cumbersome to resolve after
> the fact.
>
> I would like to take this through the KVM tree, as I don't expect the PAT/MTRR
> code to see much change in the near future, and IIRC the original motiviation
> of the VMX MSR cleanups was to prepare for KVM feature enabling (FRED maybe?).

x86 folks, can I get Acks/reviews/NAKs on patches 1-2? I'd like to land this
series in 6.12 as there is KVM feature enabling work that builds on top. It's
not a hard dependency, but having these cleanups in place would make my life easier.

Thanks!