From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FE65F549; Wed, 6 Mar 2024 10:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709719724; cv=none; b=cZ81Ug9lcqxgiheTAIbk/ll3iOjs2hFzHBIVcumGRoZs32eFytFV+LcnM8b7S7cqovRd7Do5cUE7bhEwUO6Dw/ZWwMMfrtLVHkydVIbUsLuWSLHVbvMTUDGcVsUNtRiFt2RuqSjjT0RM0N1a9qL34SlgGWjFU2YTJA+lHug4GAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709719724; c=relaxed/simple; bh=8uRZFPs9MOHH6l9eL3ZLYPLG5SB90bi0hB1yMklhULc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=R47gIgqwMAJiNnnRxpyI4URe8OuL1KNoNc7COa1jGykOTUrs51Ro7hoN9d8JtaC/ZN9MIBr7BEDlJ+gsM9nCcL9T1GPUh+XEIcb3C54Zr93nuq6pmNGCu1jYhrG32oM+znYvexntfFvbYju332DYEVBDgrjPDSDOYKQzwjHICvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BMq0PKCr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BMq0PKCr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 362F6C433C7; Wed, 6 Mar 2024 10:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709719724; bh=8uRZFPs9MOHH6l9eL3ZLYPLG5SB90bi0hB1yMklhULc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BMq0PKCrT3S6Z/INMsvyKQvjOBJm8VEEzbOk4/lkAASQM4tf39FyC9mp0cUngp7ku TNIqYsrW0nfJXNfQxS2QuxKsBvR6elonYQJCiro6L7P6g93XWQHodV/eFH3Ern6BSr VTsTuv45OFzjgN0QbJz08zoTQR8d9VlOmjnzaN6xSAwD4D6fF1dsrJJQok7DXz3nVJ uhq0fi3G0MnfGLgGRI/9XoYeYKBFBT/Re3QQMAEBjmDEqQM6BDP9tipAMbT2WEvyZ/ imLNMVQECwGjlotyQ32rk9Ew8hlsYpeTJFU5F/kXMqk4RUptkKndYgOQeyhj/dQjsL irqNLXP1VkJSA== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rhoCY-009tGy-0Z; Wed, 06 Mar 2024 10:08:42 +0000 Date: Wed, 06 Mar 2024 10:08:40 +0000 Message-ID: <878r2vr7tj.wl-maz@kernel.org> From: Marc Zyngier To: Krister Johansen Cc: stable@vger.kernel.org, Oliver Upton , James Morse , Alexandru Elisei , David Matlack , kvm@vger.kernel.org Subject: Re: [PATCH 5.15.y v2 0/2] fix softlockups in stage2_apply_range() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: kjlx@templeofstupid.com, stable@vger.kernel.org, oliver.upton@linux.dev, james.morse@arm.com, alexandru.elisei@arm.com, dmatlack@google.com, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 06 Mar 2024 00:49:34 +0000, Krister Johansen wrote: > > Hi Stable Team, > In 5.15, unmapping large kvm vms on arm64 can generate softlockups. My team has > been hitting this when tearing down VMs > 100Gb in size. > > Oliver fixed this with the attached patches. They've been in mainline since > 6.1. > > I tested on 5.15.150 with these patches applied. When they're present, > both the dirty_log_perf_test detailed in the second patch, and > kvm_page_table_test no longer generate softlockups when unmapping VMs > with large memory configurations. > > Would you please consider these patches for inclusion in an upcoming 5.15 > release? > > Change in v2: I ran format-patch without the --from option which incorrectly > generated the first series without leaving Oliver in place as the author. The > v2 should retain the correct authorship. Apologies for the mistake. Thanks for this. FWIW, Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.