From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexander Graf <agraf@suse.de>,
virtualization@lists.linux-foundation.org
Cc: kvm@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH] virtio-blk: Don't free ida when disk is in use
Date: Thu, 20 Dec 2012 14:45:13 +1030 [thread overview]
Message-ID: <878v8t1hri.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1355946015-25879-1-git-send-email-agraf@suse.de>
Alexander Graf <agraf@suse.de> writes:
> When a file system is mounted on a virtio-blk disk, we then remove it
> and then reattach it, the reattached disk gets the same disk name and
> ids as the hot removed one.
>
> This leads to very nasty effects - mostly rendering the newly attached
> device completely unusable.
>
> Trying what happens when I do the same thing with a USB device, I saw
> that the sd node simply doesn't get free'd when a device gets forcefully
> removed.
>
> Imitate the same behavior for vd devices. This way broken vd devices
> simply are never free'd and newly attached ones keep working just fine.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
I think deserves a CC:stable, no?
I've put it in my pending queue for *next* merge window for now...
Thanks,
Rusty.
next prev parent reply other threads:[~2012-12-20 4:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 19:40 [PATCH] virtio-blk: Don't free ida when disk is in use Alexander Graf
2012-12-20 4:15 ` Rusty Russell [this message]
2012-12-20 8:46 ` Asias He
2012-12-20 9:41 ` Alexander Graf
2012-12-21 1:48 ` Asias He
2013-01-02 5:09 ` Rusty Russell
2012-12-20 10:54 ` Michael S. Tsirkin
2012-12-20 11:27 ` Alexander Graf
2012-12-20 11:38 ` Michael S. Tsirkin
2012-12-20 11:47 ` Alexander Graf
2012-12-21 2:02 ` Asias He
2012-12-21 1:58 ` Asias He
2012-12-21 1:57 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v8t1hri.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox