From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 3/5] tools/kvm/9p: Don't follow symlink on server Date: Sun, 19 Jun 2011 10:47:33 +0530 Message-ID: <87aade1jte.fsf@linux.vnet.ibm.com> References: <1308419348-31934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308419348-31934-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308423073.3766.6.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:45429 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789Ab1FSFRp (ORCPT ); Sun, 19 Jun 2011 01:17:45 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e32.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5J55t4T001136 for ; Sat, 18 Jun 2011 23:05:55 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5J5HedR178032 for ; Sat, 18 Jun 2011 23:17:40 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5INHdE7022740 for ; Sat, 18 Jun 2011 17:17:40 -0600 In-Reply-To: <1308423073.3766.6.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, 18 Jun 2011 14:51:13 -0400, Sasha Levin wrote: > On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote: > > Use lstat instead of stat > > This patch should probably come after 9p2000.u support is added, since > now we transparently work 'through' symlinks (because legacy 9p2000 > doesn't support them). > Once 9p2000.u support is added we could represent symlinks and then a > switch to lstat might be due. > Shouldn't we aim to support 9p2000.L directly rather than supporting all the three versions of protocol ? Linux guest have good support for 9p2000.L Do you think the patch breaks any of the expectation of 9p2000 ?. It would be nice to get the correct file attributes when fetching attributes from the server, irrespective of whether client support symlink or not. -aneesh