Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"David Hildenbrand" <david@kernel.org>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH v5 15/62] qom: convert enum properties to QAPI-aware registration
Date: Tue, 13 Oct 2026 15:40:04 +0200	[thread overview]
Message-ID: <87bj8xyb0r.fsf@pond.sub.org> (raw)
In-Reply-To: <20260911-qom-qapi-v5-15-7732a55b7760@redhat.com> ("Marc-André Lureau"'s message of "Fri, 11 Sep 2026 20:34:49 +0400")

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Convert all callers of object_class_property_add_enum() to use the new
> object_class_property_add_qapi_enum() with the QAPI_ENUM_PROP()
> macro, which provides type information via QAPITypeInfo instead of
> raw lookup tables and string type names.
>
> This enables QMP introspection to report accurate QAPI type names
> for enum properties. Where a separate set_description call was used,
> the description is now embedded in the QAPI_ENUM_PROP initializer.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Fails qom-test for me:

    TAP version 14
    # random seed: R02Sae50f1988119a1a5ffa825624a2a4a56
    1..9
    # Start of x86_64 tests
    # Start of qom tests
    # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-1378795.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1378795.qmp,id=char0 -object monitor-qmp,id=qmp0,chardev=char0 -display none -audio none -run-with exit-with-parent=on -machine none -object memory-backend-ram,id=node0,size=65536  -accel qtest
    ok 1 /x86_64/qom/none
    # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-1378795.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1378795.qmp,id=char0 -object monitor-qmp,id=qmp0,chardev=char0 -display none -audio none -run-with exit-with-parent=on -machine pc-i440fx-11.1 -object memory-backend-ram,id=node0,size=65536  -accel qtest
    qemu-system-x86_64: ../qom/qom-qmp-cmds.c:41: qom_property_info: Assertion `prop->qapi_type->masked_name' failed.
    Broken pipe
    ../tests/qtest/libqtest.c:210: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)

PATCH 58 seems to fix it.


  reply	other threads:[~2026-10-13 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260911-qom-qapi-v5-0-7732a55b7760@redhat.com>
2026-09-11 16:34 ` [PATCH v5 15/62] qom: convert enum properties to QAPI-aware registration Marc-André Lureau
2026-10-13 13:40   ` Markus Armbruster [this message]
2026-09-11 16:34 ` [PATCH v5 17/62] qom: convert struct " Marc-André Lureau
2026-09-11 16:34 ` [PATCH v5 25/62] sev: convert OnOffAuto legacy-vm-type property " Marc-André Lureau
2026-09-11 16:35 ` [PATCH v5 28/62] accel/kvm: convert OnOffSplit " Marc-André Lureau
2026-09-11 16:35 ` [PATCH v5 35/62] qom: convert scalar properties " Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bj8xyb0r.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@kernel.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox