From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA624EB64D8 for ; Wed, 14 Jun 2023 16:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbjFNQHI (ORCPT ); Wed, 14 Jun 2023 12:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjFNQHG (ORCPT ); Wed, 14 Jun 2023 12:07:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B312B5 for ; Wed, 14 Jun 2023 09:07:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E21363C4E for ; Wed, 14 Jun 2023 16:07:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8C7BC433C8; Wed, 14 Jun 2023 16:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686758821; bh=/r6fdKCJUAuhajNoRQPQaUxEvrIU0vHzZIEJ1GzJpnE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qbK5EooCYLobN7jXxYBxiPx9/iHnGqXfD7liRUJcIZkCiw5Czt6Dvs1rhyIS5d1Fc +MLZkaA9MgnB7fpUKtFfiHjpBi74vwnsCNnPj0Rodte4O9VtJOshjylallZx/8fRB1 IuNuq9ugLk8l/CfNHu/gKoejq8UvCbuJp4tG9vXLTtMGnO00BKBYFiXvIVxjIttLuS 1FZHEwvR2MzizQj80KYXE4CVyL3w4EEYJvfuQG7BnI4YxQOj0aK31cnzV4o2e23b2l 3NXbrNJNEVcKOWfPCm/1HyWpP9bqjrlAZBTUHgphsFaXp6bH+pRBFEATHu0hZ4hAJL rvGqRpIG1g6cQ== Received: from [77.240.177.73] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q9T1O-005NTK-E2; Wed, 14 Jun 2023 17:06:58 +0100 Date: Wed, 14 Jun 2023 17:06:58 +0100 Message-ID: <87bkhiqb8d.wl-maz@kernel.org> From: Marc Zyngier To: Shaoqin Huang Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Quentin Perret , Will Deacon , Fuad Tabba Subject: Re: [PATCH v3 04/17] arm64: Add KVM_HVHE capability and has_hvhe() predicate In-Reply-To: <8f7d7285-b21d-23b0-793b-70ee008cb45b@redhat.com> References: <20230609162200.2024064-1-maz@kernel.org> <20230609162200.2024064-5-maz@kernel.org> <8f7d7285-b21d-23b0-793b-70ee008cb45b@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 77.240.177.73 X-SA-Exim-Rcpt-To: shahuang@redhat.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, qperret@google.com, will@kernel.org, tabba@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 14 Jun 2023 08:35:13 +0100, Shaoqin Huang wrote: > > Hi Marc, > > Should we have a document about the hVHE? Because it's a sw feature, > there is no spec about it. And later people may need to read the code > itself to understand what is hVHE. I'm planning to eventually do that once the hVHE code actually does something useful. So far, it doesn't really do much. But what I really want is to *hide* this low level option, and have it driven by something like "kvm-arm.mode=hvhe,protected". It is just that writing a parser is hard at the point where this is evaluated (we don't have much of the kernel running). > > On 6/10/23 00:21, Marc Zyngier wrote: > > Expose a capability keying the hVHE feature as well as a new > > predicate testing it. Nothing is so far using it, and nothing > > is enabling it yet. > > > > Signed-off-by: Marc Zyngier > Besides that, the code itself LGTM. > > Reviewed-by: Shaoqin Huang Thanks, M. -- Without deviation from the norm, progress is not possible.