From: Jonathan Corbet <corbet@lwn.net>
To: Yan-Jie Wang <yanjiewtw@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Andre Przywara <andre.przywara@arm.com>,
Avi Kivity <avi@redhat.com>, Yan-Jie Wang <yanjiewtw@gmail.com>,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
trivial@kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2] docs: clarify KVM related kernel parameters' descriptions
Date: Fri, 19 May 2023 08:56:43 -0600 [thread overview]
Message-ID: <87bkignzdg.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230503081530.19956-1-yanjiewtw@gmail.com>
Yan-Jie Wang <yanjiewtw@gmail.com> writes:
> The descriptions of certain KVM related kernel parameters can be
> confusing. They state "Disable ...," which may make people think that
> setting them to 1 will disable the associated feature when in fact the
> opposite is true.
>
> This commit addresses this issue by revising the descriptions of these
> parameters by using "Control..." rather than "Enable/Disable...".
> 1==enabled or 0==disabled can be communicated by the description of
> default value such as "1 (enabled)" or "0 (disabled)".
>
> Also update the description of KVM's default value for kvm-intel.nested
> as it is enabled by default.
>
> Signed-off-by: Yan-Jie Wang <yanjiewtw@gmail.com>
> ---
> Changes in v2:
> - Revise the descriptions based on Sean's suggesstion.
> - Fix the wrong default value of kvm-intel.nested
> ---
> .../admin-guide/kernel-parameters.txt | 53 ++++++++++---------
> 1 file changed, 29 insertions(+), 24 deletions(-)
Applied, thanks.
jon
prev parent reply other threads:[~2023-05-19 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 11:25 [PATCH] docs: clarify KVM related kernel parameters' descriptions Yan-Jie Wang
2023-05-02 17:12 ` Sean Christopherson
2023-05-03 7:15 ` Yan-Jie Wang
2023-05-03 8:15 ` [PATCH v2] " Yan-Jie Wang
2023-05-19 14:56 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkignzdg.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=andre.przywara@arm.com \
--cc=avi@redhat.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rdunlap@infradead.org \
--cc=seanjc@google.com \
--cc=trivial@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox