Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

Richard Henderson
2020-10-03T09:13:22Z

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote:
> +++ b/meson.build
> @@ -529,6 +529,7 @@ kconfig_external_symbols = [
> ]
> ignored = ['TARGET_XML_FILES', 'TARGET_ABI_DIR', 'TARGET_DIRS']
>
> +fs = import('fs')

Note that I have this in the capstone update, and I placed it closer to the top
of the file with some other imports.

> foreach target : target_dirs
> config_target = keyval.load(meson.current_build_dir() / target / 'config-target.mak')
>
> @@ -569,8 +570,13 @@ foreach target : target_dirs
> endforeach
>
> config_devices_mak = target + '-config-devices.mak'
> + target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / 'Kconfig'
> + minikconf_input = ['default-configs' / target + '.mak', 'Kconfig']
> + if fs.is_file(target_kconfig)

Missing a meson.current_source_dir()?
Leastwise that was a comment that Paolo had for me.

r~