From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] virtio-spec: Fix wrong bit number of device status
Date: Wed, 08 Jun 2011 09:05:26 +0930
Message-ID: <87boy9gqpt.fsf@rustcorp.com.au>
References: <1307451139-20613-1-git-send-email-akong@redhat.com> <20110607130942.GA16234@t400>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Amos Kong <akong@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:60751 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751164Ab1FHAqB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Jun 2011 20:46:01 -0400
In-Reply-To: <20110607130942.GA16234@t400>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 7 Jun 2011 21:09:42 +0800, Amos Kong <akong@redhat.com> wrote:
> 
> qemu-kvm/hw/virtio_config.h:
>  #define VIRTIO_CONFIG_S_ACKNOWLEDGE     1
>  #define VIRTIO_CONFIG_S_DRIVER          2
>  #define VIRTIO_CONFIG_S_DRIVER_OK       4
>  #define VIRTIO_CONFIG_S_FAILED          0x80
> 
> virtio-spec:
> ACKNOWLEDGE(1) :
> DRIVER(2)      :
> DRIVER_OK(3)   :
> FAILED(128)    :
> 
> The spec refers to bit numbers and the headers use absolute numbers,
> they are not consistent.
> 
> it shoule be 'FAILED(8)'.
> 2^(8-1) = 128
> 
> Changes from V1:
> - Fix wrong patch body
> 
> Signed-off-by: Amos Kong <akong@redhat.com>

Thanks, applied!
Rusty.