From: Andi Kleen <andi@firstfloor.org>
To: "Mohammed Gamal" <m.gamal005@gmail.com>
Cc: kvm@vger.kernel.org, avi@qumranet.com, riel@surriel.com
Subject: Re: [PATCH] x86_emulate: Emulate nop (0x90) instruction
Date: Sat, 14 Jun 2008 15:26:36 +0200 [thread overview]
Message-ID: <87bq24no4z.fsf@basil.nowhere.org> (raw)
In-Reply-To: <52d4a3890806140450k14a13025i3dd3a60187940804@mail.gmail.com> (Mohammed Gamal's message of "Sat, 14 Jun 2008 14:50:59 +0300")
"Mohammed Gamal" <m.gamal005@gmail.com> writes:
> ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs,
> @@ -1560,6 +1560,9 @@ special_insn:
> if (rc != 0)
> goto done;
> break;
> + case 0x90: /* nop */
> + if(! (c->rex_prefix & 1) )
> + break;
> case 0x9c: /* pushf */
> c->src.val = (unsigned long) ctxt->eflags;
> emulate_push(ctxt);
Is falling through to pushf really correct? And not sure what the if checks.
iirc it should be just
case 0x90: /* nop */
break;
BTW there are lots more nop encodings.
-Andi
next prev parent reply other threads:[~2008-06-14 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 11:50 [PATCH] x86_emulate: Emulate nop (0x90) instruction Mohammed Gamal
2008-06-14 13:26 ` Andi Kleen [this message]
2008-06-14 13:35 ` Mohammed Gamal
2008-06-14 15:08 ` Andi Kleen
2008-06-14 15:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bq24no4z.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox