From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C168134573E; Thu, 21 Aug 2025 13:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783843; cv=none; b=c85l3kD20/egt4XJTZMsOKtu/HCwRPj87skasUfIeFHNGr7bB+06QWYNZIiaw6CFvg8fKokuQsE1iXcdRrdydtcfANkmw/Z9pC5aoDVZpKwhycarZZ/ZEbYPE8BghnZstgSl+ZxFSCtUn1cLB8BwBst+T9+6CkVIOjr7NnLLXOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783843; c=relaxed/simple; bh=51ppjBwI5H4RwL9SltGTpPChSEY3LYuPKVmovIKwViE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=p2WjKsmwCDic/QaxDgfvzfkv3NcQ098vqZ80IDRmpAtAED5+qS/g5ZDJVO+a55JTsc9VoKYe+Ak7cpPZ6wRLHlYyJX5AOHHKDr/fudT91db1VQprkSJaYG9izmV2wgQM8hTbegqAHgRfcthy82nT7mwXI2XFrpbMvxhDxD+8/MU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i1KlP9rL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i1KlP9rL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A248C4CEED; Thu, 21 Aug 2025 13:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755783843; bh=51ppjBwI5H4RwL9SltGTpPChSEY3LYuPKVmovIKwViE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i1KlP9rL9f6yeE22Pi4q77QUz9CpLh4Y1QvJYtG/vpYEd7cLx02hTL9ZvoIp7X/4I ++u5YMAf3t/9jCYhsWJ3sZeZ4YqvUJabaNCXRv8eR8Mm9FNbcF1VCOeG9jowjFHC8g BXBxJpmA/Po3fHPCnxTV8mXz90tMkYai1X0iYdDowR2N4a/CWcOdZJ+CN3hQYUjHad YpBsl811mtLr+vXWDTaNCQan9nNxyCS4byF1FHlC1RgzPgtLSPflEDbvMEpBVa+SKD 5OiJ52ktgd499Ckys2O9yIdrOG5BsT/O5D+KThJFV8x0Ynbym/ZgutZzHP+iT8RMTd wztv7nAaWB6/A== Received: from host86-149-246-145.range86-149.btcentralplus.com ([86.149.246.145] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1up5a0-009l8u-7K; Thu, 21 Aug 2025 14:43:48 +0100 Date: Thu, 21 Aug 2025 14:43:47 +0100 Message-ID: <87cy8okcx8.wl-maz@kernel.org> From: Marc Zyngier To: Ben Horgan Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Will Deacon , Catalin Marinas , Cornelia Huck Subject: Re: [PATCH v3 6/6] KVM: arm64: Get rid of ARM64_FEATURE_MASK() In-Reply-To: References: <20250817202158.395078-1-maz@kernel.org> <20250817202158.395078-7-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 86.149.246.145 X-SA-Exim-Rcpt-To: ben.horgan@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, will@kernel.org, catalin.marinas@arm.com, cohuck@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 21 Aug 2025 12:29:43 +0100, Ben Horgan wrote: > > Hi Marc, > > On 8/17/25 21:21, Marc Zyngier wrote: > > The ARM64_FEATURE_MASK() macro was a hack introduce whilst the > > automatic generation of sysreg encoding was introduced, and was > > too unreliable to be entirely trusted. > > > > We are in a better place now, and we could really do without this > > macro. Get rid of it altogether. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/include/asm/sysreg.h | 3 -- > > arch/arm64/kvm/arm.c | 8 ++-- > > arch/arm64/kvm/sys_regs.c | 40 +++++++++---------- > > tools/arch/arm64/include/asm/sysreg.h | 3 -- > > .../selftests/kvm/arm64/aarch32_id_regs.c | 2 +- > > .../selftests/kvm/arm64/debug-exceptions.c | 12 +++--- > > .../testing/selftests/kvm/arm64/no-vgic-v3.c | 4 +- > > .../selftests/kvm/arm64/page_fault_test.c | 6 +-- > > .../testing/selftests/kvm/arm64/set_id_regs.c | 8 ++-- > > .../selftests/kvm/arm64/vpmu_counter_access.c | 2 +- > > .../selftests/kvm/lib/arm64/processor.c | 6 +-- > > 11 files changed, 44 insertions(+), 50 deletions(-) > > > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > > index d5b5f2ae1afaa..6604fd6f33f45 100644 > > --- a/arch/arm64/include/asm/sysreg.h > > +++ b/arch/arm64/include/asm/sysreg.h > > @@ -1142,9 +1142,6 @@ > > #define ARM64_FEATURE_FIELD_BITS 4 > While you're at it, consider getting rid of ARM64_FEATURE_FIELD_BITS > too. This is only used in the set_id_regs.c selftest. I don't really understand what this test (like most tests) is doing, so I'm not going to touch it. If you figure it out, feel free to send a patch. Thanks, M. -- Jazz isn't dead. It just smells funny.