public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Marc Hartmayer" <mhartmay@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>, Thomas Huth <thuth@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	kvm@vger.kernel.org
Subject: Re: [RFC kvm-unit-tests PATCH] build: fix .aux.o target building
Date: Wed, 05 Jun 2024 12:42:30 +0200	[thread overview]
Message-ID: <87cyovekmh.fsf@linux.ibm.com> (raw)
In-Reply-To: <20240605081623.8765-1-npiggin@gmail.com>

On Wed, Jun 05, 2024 at 06:16 PM +1000, Nicholas Piggin <npiggin@gmail.com> wrote:
> Here's another oddity I ran into with the build system. Try run make
> twice. With arm64 and ppc64, the first time it removes some intermediate
> files and the second causes another rebuild of several files. After
> that it's fine. s390x seems to follow a similar pattern but does not
> suffer from the problem. Also, the .PRECIOUS directive is not preventing
> them from being deleted inthe first place. So... that probably means I
> haven't understood it properly and the fix may not be correct, but it
> does appear to DTRT... Anybody with some good Makefile knowledge might
> have a better idea.
>

$ make clean -j &>/dev/null && make -d
…
Successfully remade target file 'all'.
Removing intermediate files...
rm powerpc/emulator.aux.o powerpc/tm.aux.o powerpc/spapr_hcall.aux.o powerpc/interrupts.aux.o powerpc/selftest.aux.o powerpc/smp.aux.o powerpc/selftest-migration.aux.o powerpc/spapr_vpa.aux.o powerpc/sprs.aux.o powerpc/rtas.aux.o powerpc/memory-verify.aux.o

So an easier fix would be to add %.aux.o to .PRECIOUS (but that’s probably still not clean).

.PRECIOUS: %.o %.aux.o

Fixed the issue (I’ve tested on ppc64 only).

>
>
-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

  reply	other threads:[~2024-06-05 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  8:16 [RFC kvm-unit-tests PATCH] build: fix .aux.o target building Nicholas Piggin
2024-06-05 10:42 ` Marc Hartmayer [this message]
2024-06-05 10:49   ` Andrew Jones
2024-06-05 10:53   ` Nicholas Piggin
2024-06-05 15:07     ` Marc Hartmayer
2024-06-06  3:49       ` Nicholas Piggin
2024-06-06  7:58         ` Marc Hartmayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyovekmh.fsf@linux.ibm.com \
    --to=mhartmay@linux.ibm.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox