From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEE8C2FC0F for ; Thu, 17 Aug 2023 03:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347841AbjHQD02 (ORCPT ); Wed, 16 Aug 2023 23:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347840AbjHQD0L (ORCPT ); Wed, 16 Aug 2023 23:26:11 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7C0268F; Wed, 16 Aug 2023 20:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1692242763; bh=ZlmenDsbW60G7uJu2veM5G1rkGG/EEMpV5h+3Oe3uEg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ryZg14br4OQt+fo/T+XGTbDRZaG5g03gpLyVNOZrOIHHv8Np/CnItphXx1cwBuhwk +3YrrFxzkcHaAC5mdnGAtp0kIoh/44J1Iqe0yuzTbl4nvzNvvHPUmztIfRzRPUO46J rTHOE7YKTOwBk6BEhQM8RQfcCakGK1JrUsHlWS2iMHx6GXf178hGz7lNyH8ZbVHo0W w3YBAvMyotpKM5+Fya4Dkm31h2f+2rU68XjkixrFAKJeYltmHO17tr0ZpENprendQa IZTAzmZjOvyEQI0QVR3jf2bjbvao2IU16QRKTvDAFkWfsNl5lE5MIadIdP2yqBsVCx gfk2KWTfNkK6g== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RR9Q250Ymz4wb0; Thu, 17 Aug 2023 13:26:02 +1000 (AEST) From: Michael Ellerman To: Jordan Niethe , linuxppc-dev@lists.ozlabs.org Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, npiggin@gmail.com, mikey@neuling.org, paulus@ozlabs.org, vaibhav@linux.ibm.com, sbhat@linux.ibm.com, gautam@linux.ibm.com, kconsul@linux.vnet.ibm.com, amachhiw@linux.vnet.ibm.com, Jordan Niethe Subject: Re: [PATCH v3 1/6] KVM: PPC: Use getters and setters for vcpu register state In-Reply-To: <20230807014553.1168699-2-jniethe5@gmail.com> References: <20230807014553.1168699-1-jniethe5@gmail.com> <20230807014553.1168699-2-jniethe5@gmail.com> Date: Thu, 17 Aug 2023 13:25:58 +1000 Message-ID: <87cyzm73jt.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Jordan Niethe writes: > There are already some getter and setter functions used for accessing > vcpu register state, e.g. kvmppc_get_pc(). There are also more > complicated examples that are generated by macros like > kvmppc_get_sprg0() which are generated by the SHARED_SPRNG_WRAPPER() > macro. > ... > diff --git a/arch/powerpc/include/asm/kvm_book3s.h b/arch/powerpc/include= /asm/kvm_book3s.h > index bbf5e2c5fe09..1a7e837ea2d5 100644 > --- a/arch/powerpc/include/asm/kvm_book3s.h > +++ b/arch/powerpc/include/asm/kvm_book3s.h > @@ -403,10 +413,121 @@ static inline ulong kvmppc_get_fault_dar(struct kv= m_vcpu *vcpu) ... > + > +#ifdef CONFIG_VSX > +static inline void kvmppc_get_vsx_vr(struct kvm_vcpu *vcpu, int i, vecto= r128 *v) > +{ > + *v =3D vcpu->arch.vr.vr[i]; > +} This is causing build errors if VSX is disabled. I'm using g5_defconfig plus: CONFIG_VIRTUALIZATION=3Dy CONFIG_KVM_BOOK3S_64=3Dy CONFIG_KVM_BOOK3S_64_PR=3Dy Which gives me: ../arch/powerpc/kvm/powerpc.c: In function =E2=80=98kvmppc_set_vmx_dword= =E2=80=99: ../arch/powerpc/kvm/powerpc.c:1061:9: error: implicit declaration of func= tion =E2=80=98kvmppc_get_vsx_vr=E2=80=99; did you mean =E2=80=98kvmppc_get_= vsx_fpr=E2=80=99? [-Werror=3Dimplicit-function-declaration] 1061 | kvmppc_get_vsx_vr(vcpu, index, &val.vval); | ^~~~~~~~~~~~~~~~~ | kvmppc_get_vsx_fpr ../arch/powerpc/kvm/powerpc.c:1063:9: error: implicit declaration of func= tion =E2=80=98kvmppc_set_vsx_vr=E2=80=99; did you mean =E2=80=98kvmppc_set_= vsx_fpr=E2=80=99? [-Werror=3Dimplicit-function-declaration] 1063 | kvmppc_set_vsx_vr(vcpu, index, &val.vval); | ^~~~~~~~~~~~~~~~~ | kvmppc_set_vsx_fpr In file included from ../arch/powerpc/kvm/powerpc.c:25: ../arch/powerpc/kvm/powerpc.c: In function =E2=80=98kvm_vcpu_ioctl_get_on= e_reg=E2=80=99: ../arch/powerpc/kvm/powerpc.c:1729:52: error: implicit declaration of fun= ction =E2=80=98kvmppc_get_vscr=E2=80=99; did you mean =E2=80=98kvmppc_get_s= r=E2=80=99? [-Werror=3Dimplicit-function-declaration] 1729 | val =3D get_reg_val(reg->id, kvmppc_get_v= scr(vcpu)); | ^~~~~~~~~~~~~~~ ../arch/powerpc/include/asm/kvm_ppc.h:412:29: note: in definition of macr= o =E2=80=98get_reg_val=E2=80=99 412 | case 4: __u.wval =3D (reg); break; \ | ^~~ ../arch/powerpc/kvm/powerpc.c: In function =E2=80=98kvm_vcpu_ioctl_set_on= e_reg=E2=80=99: ../arch/powerpc/kvm/powerpc.c:1780:25: error: implicit declaration of fun= ction =E2=80=98kvmppc_set_vscr=E2=80=99; did you mean =E2=80=98kvmppc_set_f= scr=E2=80=99? [-Werror=3Dimplicit-function-declaration] 1780 | kvmppc_set_vscr(vcpu, set_reg_val(reg->id= , val)); | ^~~~~~~~~~~~~~~ | kvmppc_set_fscr Looking at kvm_vcpu_arch, the thread_vr_state and members are guarded by CONFIG_ALTIVEC, not CONFIG_VSX. Switching to that fixes the build. Whether it makes sense to be getting/setting those registers when VSX=3Dn is not immediately clear, but is a separate problem. cheers