From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC40C64EC7 for ; Sat, 25 Feb 2023 10:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbjBYKcx (ORCPT ); Sat, 25 Feb 2023 05:32:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjBYKcv (ORCPT ); Sat, 25 Feb 2023 05:32:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D2D710D0 for ; Sat, 25 Feb 2023 02:32:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC5FAB80907 for ; Sat, 25 Feb 2023 10:32:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65D39C433D2; Sat, 25 Feb 2023 10:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677321167; bh=GWWCYFWq7FJcty/g4faf96mwq52yRHHXEaQ/c2U22o4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bPgOumt43neLBbsnV9VJ7q5Vp9nkVia0+yEQgAKax39vbwpsWliRiSoYWRYcXmKVt HttypUTrEOJ+ejh16ha3rIrT135cJVQ4TAG+bgUd5Gv4JcH8C9Y0CZSIQJ8y6bW5Ta lzGRIgXAj58rsS74Go5l2bfyiLUdmdnHk5BCpcUiKSIJdx189zL7Rx4Mk5Bi1p/E9T Q3QYqDY1xaN6MSDhGpuH43mbVwvGqeLNsvuKO5XOsQjD6aHv/Qj/6/LZ3Q/t4gxt7N L/0igZtlFN2I2y/AR4bONaRhvFWtoaqCFl6tsHV4+SJg3K8Nx3vi+4SNCUkq5CpLnO LeXktVsHa86LQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVrrB-00D6vI-03; Sat, 25 Feb 2023 10:32:45 +0000 Date: Sat, 25 Feb 2023 10:32:40 +0000 Message-ID: <87cz5ydohj.wl-maz@kernel.org> From: Marc Zyngier To: Colton Lewis Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org Subject: Re: [PATCH 12/16] KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset In-Reply-To: References: <20230216142123.2638675-13-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: coltonlewis@google.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 24 Feb 2023 20:07:59 +0000, Colton Lewis wrote: > > Marc Zyngier writes: > > > diff --git a/include/kvm/arm_arch_timer.h b/include/kvm/arm_arch_timer.h > > index 62ef4883e644..e76e513b90c5 100644 > > --- a/include/kvm/arm_arch_timer.h > > +++ b/include/kvm/arm_arch_timer.h > > @@ -29,6 +29,11 @@ struct arch_timer_offset { > > * structure. If NULL, assume a zero offset. > > */ > > u64 *vm_offset; > > + /* > > + * If set, pointer to one of the offsets in the vcpu's sysreg > > + * array. If NULL, assume a zero offset. > > + */ > > + u64 *vcpu_offset; > > }; > > > struct arch_timer_vm_offsets { > > -- > > 2.34.1 > > This pointer isn't initialized until next commit and this commit is > small so I think it should be merged with the next one. Like the rest of the vcpu structure, this is of course initialised to zero. Yes, the patch is small. It does *one* thing, which is to plug a new offset. Should it be buried into a much bigger patch? I don't think so. M. -- Without deviation from the norm, progress is not possible.