From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Michael Kelley <mikelley@microsoft.com>,
Jon Doron <arilou@gmail.com>, Wei Liu <wei.liu@kernel.org>
Cc: "kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-hyperv\@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: RE: [PATCH v4 2/5] x86/hyper-v: Add synthetic debugger definitions
Date: Thu, 12 Mar 2020 14:51:23 +0100 [thread overview]
Message-ID: <87d09hr89w.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <MW2PR2101MB10522800EB048383C227F556D7FF0@MW2PR2101MB1052.namprd21.prod.outlook.com>
Michael Kelley <mikelley@microsoft.com> writes:
> I'm flexible, and trying to not be a pain-in-the-neck. :-) What would
> the KVM guys think about putting the definitions in a KVM specific
> #include file, and clearly marking them as deprecated, mostly
> undocumented, and used only to support debugging old Windows
> versions?
I *think* we should do the following: defines which *are* present in
TLFS doc (e.g. HV_FEATURE_DEBUG_MSRS_AVAILABLE,
HV_STATUS_OPERATION_DENIED, ...) go to asm/hyperv-tlfs.h, the rest
(syndbg) stuff goes to kvm-specific include (I'd suggest we just use
hyperv.h we already have).
What do you think?
--
Vitaly
next prev parent reply other threads:[~2020-03-12 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:20 [PATCH v4 0/5] x86/kvm/hyper-v: add support for synthetic debugger Jon Doron
2020-03-09 18:20 ` [PATCH v4 1/5] x86/kvm/hyper-v: Explicitly align hcall param for kvm_hyperv_exit Jon Doron
2020-03-10 16:55 ` Vitaly Kuznetsov
2020-03-10 17:14 ` Jon Doron
2020-03-09 18:20 ` [PATCH v4 2/5] x86/hyper-v: Add synthetic debugger definitions Jon Doron
2020-03-09 21:00 ` Michael Kelley
2020-03-10 3:24 ` Jon Doron
2020-03-10 3:53 ` Michael Kelley
2020-03-10 4:28 ` Jon Doron
2020-03-10 14:23 ` Wei Liu
2020-03-12 13:51 ` Vitaly Kuznetsov [this message]
2020-03-12 14:59 ` Michael Kelley
2020-03-12 19:12 ` Jon Doron
2020-03-12 19:32 ` Michael Kelley
2020-03-12 19:34 ` Jon Doron
2020-03-09 18:20 ` [PATCH v4 3/5] x86/kvm/hyper-v: Add support for synthetic debugger capability Jon Doron
2020-03-09 18:20 ` [PATCH v4 4/5] x86/kvm/hyper-v: enable hypercalls regardless of hypercall page Jon Doron
2020-03-09 18:20 ` [PATCH v4 5/5] x86/kvm/hyper-v: Add support for synthetic debugger via hypercalls Jon Doron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09hr89w.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=arilou@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox