From: Markus Armbruster <armbru@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Shraddha Barke <shraddha.6596@gmail.com>,
kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/3] Target-microblaze: Remove unnecessary variable
Date: Mon, 05 Oct 2015 07:18:10 +0200 [thread overview]
Message-ID: <87d1wtao6l.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <56100743.4010604@msgid.tls.msk.ru> (Michael Tokarev's message of "Sat, 03 Oct 2015 19:50:11 +0300")
Michael Tokarev <mjt@tls.msk.ru> writes:
> 25.09.2015 11:37, Shraddha Barke wrote:
>> Compress lines and remove the variable .
>
> Applied to -trivial, removing this piece of commit message:
>
> ---
>> Change made using Coccinelle script
>>
>> @@
>> expression ret;
>> @@
>> - if (ret) return ret;
>> - return 0;
>> + return ret;
>> @@
>> local idexpression ret;
>> expression e;
>> @@
>> - ret = e;
>> - return ret;
>> + return e;
>> @@
>> type T; identifier i;
>> @@
>> - T i;
>> ... when != i
> ---
Why? I like having the semantic patch in the commit message when
there's any chance we'll want do the same mechanical change again later.
You could save space and include it by reference, though: "Same
Coccinelle semantic patch as is commit 74c373e".
next prev parent reply other threads:[~2015-10-05 5:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:37 [PATCH 1/3] Target-microblaze: Remove unnecessary variable Shraddha Barke
2015-09-25 8:37 ` [PATCH 2/3] Hw: timer: " Shraddha Barke
2015-09-25 21:35 ` [Qemu-devel] " Peter Maydell
2015-09-25 8:37 ` [PATCH 3/3] Target-ppc: " Shraddha Barke
2015-09-26 16:15 ` [Qemu-devel] " Eric Blake
2015-09-28 10:56 ` Paolo Bonzini
2015-10-03 16:50 ` Michael Tokarev
2015-10-03 16:50 ` [PATCH 1/3] Target-microblaze: " Michael Tokarev
2015-10-05 5:18 ` Markus Armbruster [this message]
2015-10-05 7:18 ` Michael Tokarev
2015-10-05 7:53 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1wtao6l.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).