From: Thomas Gleixner <tglx@linutronix.de>
To: Nipun Gupta <nipun.gupta@amd.com>,
alex.williamson@redhat.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: maz@kernel.org, git@amd.com, harpreet.anand@amd.com,
pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
michal.simek@amd.com, abhijit.gangurde@amd.com,
srivatsa@csail.mit.edu, Nipun Gupta <nipun.gupta@amd.com>
Subject: Re: [PATCH v4 1/2] genirq/msi: add wrapper msi allocation API and export msi functions
Date: Mon, 25 Mar 2024 16:06:42 +0100 [thread overview]
Message-ID: <87edbyfj0d.ffs@tglx> (raw)
In-Reply-To: <20240305043040.224127-1-nipun.gupta@amd.com>
On Tue, Mar 05 2024 at 10:00, Nipun Gupta wrote:
Subject: genirq/msi: Add MSI allocation helper and export MSI functions
> MSI functions can be for allocation and free can be directly
> used by the device drivers without any wrapper provided by
> bus drivers. So export these MSI functions.
s/can be for/for/ otherwise the sentence dos not make sense.
> Also, add a wrapper API to allocate MSIs providing only the
> number of IRQ's rather than range for simpler driver usage.
s/IRQ's/interrupts/
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Alex, feel free to pick this up with the nitpicks resolved and route it
through your tree together with the VFIO driver.
Thanks,
tglx
prev parent reply other threads:[~2024-03-25 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 4:30 [PATCH v4 1/2] genirq/msi: add wrapper msi allocation API and export msi functions Nipun Gupta
2024-03-05 4:30 ` [PATCH v4 2/2] vfio/cdx: add interrupt support Nipun Gupta
2024-03-25 15:06 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edbyfj0d.ffs@tglx \
--to=tglx@linutronix.de \
--cc=abhijit.gangurde@amd.com \
--cc=alex.williamson@redhat.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=srivatsa@csail.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox