From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v2 6/6] KVM: nVMX: optimize prepare_vmcs02{,_full} for Enlightened VMCS case
Date: Wed, 25 Jul 2018 15:26:12 +0200
Message-ID: <87effrphu3.fsf@vitty.brq.redhat.com>
References: <20180621123046.29606-1-vkuznets@redhat.com>
        <20180621123046.29606-7-vkuznets@redhat.com>
        <a826fd88-0199-8e7b-ebfc-290e936b5efc@redhat.com>
        <87va93pv6w.fsf@vitty.brq.redhat.com>
        <46052d1e-9ee1-8cee-3f7c-cf27b1cd0373@redhat.com>
        <87in53pjgv.fsf@vitty.brq.redhat.com>
        <f464b4fa-19d0-6b8b-5afe-d491b1eee08a@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: kvm@vger.kernel.org,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
        Mohammed Gamal <mmorsy@redhat.com>,
        Cathy Avery <cavery@redhat.com>, linux-kernel@vger.kernel.org,
        Jim Mattson <jmattson@google.com>,
        Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <f464b4fa-19d0-6b8b-5afe-d491b1eee08a@redhat.com> (Paolo
        Bonzini's message of "Wed, 25 Jul 2018 14:55:10 +0200")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 25/07/2018 14:50, Vitaly Kuznetsov wrote:
>>>
>>> But is L0 allowed to write to hv_clean_fields?  
>> It is kinda expected to: currently I reset it in vmx_vcpu_run() and (if
>> I remember correctly) L1 Hyper-V only clears bits in this mask when it
>> touches certain fields so if we don't set it to 'all clean' it stays
>> zeroed forever.
>
> Oh, good.  I didn't understand it was bidirectional.
>
>  So nothing stops us from doing
>> 
>>        if (hv_evmcs && vmx->nested.dirty_vmcs12)
>>                hv_evmcs->hv_clean_fields &=
>>                        ~HV_VMX_ENLIGHTENED_CLEAN_FIELD_ALL;
>> 
>> in prepare_vmcs02() I guess.
>
> In prepare_vmcs02, or rather in the enlightened VMPTRLD?
>

Doing it in nested_vmx_handle_enlightened_vmptrld() is even better: we
can simplify copy_enlightened_to_vmcs12() too!

The other place where we set dirty_vmcs12 is the newly introduced
vmx_set_nested_state() but I think I'm going to add support for eVMCS
there later and just return something like -ENOTSUPP for now. Too many
people work on nested simultaneously :-)

-- 
  Vitaly