From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks naming Date: Thu, 29 Mar 2012 15:10:01 +1030 Message-ID: <87ehscyq8u.fsf@rustcorp.com.au> References: <4F72B5B3.6020602@cn.fujitsu.com> <20120328105819.GD6194@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-scsi@vger.kernel.org, LKML , virtualization@lists.linux-foundation.org, jens.axboe@oracle.com, Tejun Heo To: "Michael S. Tsirkin" , Ren Mingxin Return-path: In-Reply-To: <20120328105819.GD6194@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: kvm.vger.kernel.org On Wed, 28 Mar 2012 12:58:21 +0200, "Michael S. Tsirkin" wrote: > On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote: > > Hi, > > > > The current virtblk's naming algorithm just supports 26^3 > > disks. If there are mass of virtblks(exceeding 26^3), there > > will be disks with the same name. > > > > According to "sd_format_disk_name()", I add function > > "virtblk_name_format()" for virtblk to support mass of > > disks. > > > > Signed-off-by: Ren Mingxin > > Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe > did. Except, maybe we should move this function into block core > instead of duplicating it? Where would be a good place to put it? > Jens, care to comment? Indeed. Cheers, Rusty. -- How could I marry someone with more hair than me? http://baldalex.org