From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301DDC433F5 for ; Tue, 15 Feb 2022 09:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235809AbiBOJ03 (ORCPT ); Tue, 15 Feb 2022 04:26:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235723AbiBOJ02 (ORCPT ); Tue, 15 Feb 2022 04:26:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 165A16CA5F for ; Tue, 15 Feb 2022 01:26:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD96BB817FF for ; Tue, 15 Feb 2022 09:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80FA3C340EB; Tue, 15 Feb 2022 09:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644917176; bh=0uA3b2nBSvB9TDUlYCZYfa1MOzWgdhJfA6Y88K472C8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tk6QOzGCeaR90RWCs7wzkf9EhmfnPW++2dJD7jKPQ32oSv7NxqR5mHG7DF/dBBJsq YMwhZtswNQjJGMAai7Hdm9WoNWFOdNz4pLu2w3ki0l1CUHfIULNsY2Guankd3BEvFP dbr/ngv2epJIqa7yvx036Zf5TwzVGo9Vz+hpV1S5csDGrLtgCE81S5Kg5W39XkjU18 b/uwc6qsNBwmBlJp2jSsu6WwmAFoG3Z6jk1bzM7Nhlg0PbH1F02OBxMp+i22IfXQd8 UE8oNm3rgiVnqvgWDYFkwlkKRpPGmNqd6pU0w/9q3HxbsMM6gXuI/RguvMtJzezwOQ ihTcUR+VC0ddA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nJu6A-0080CN-43; Tue, 15 Feb 2022 09:26:14 +0000 Date: Tue, 15 Feb 2022 09:26:13 +0000 Message-ID: <87fsok4h1m.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Jones Cc: Alexandru Elisei , pbonzini@redhat.com, thuth@redhat.com, kvm@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH] lib/devicetree: Support 64 bit addresses for the initrd In-Reply-To: <20220215073212.fp5lh4gfxk7clwwc@gator> References: <20220214120506.30617-1-alexandru.elisei@arm.com> <20220214135226.joxzj2tgg244wl6n@gator> <20220214142444.saeogrpgpx6kaamm@gator> <87k0dx4c23.wl-maz@kernel.org> <20220215073212.fp5lh4gfxk7clwwc@gator> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: drjones@redhat.com, alexandru.elisei@arm.com, pbonzini@redhat.com, thuth@redhat.com, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 15 Feb 2022 07:32:12 +0000, Andrew Jones wrote: > > On Mon, Feb 14, 2022 at 05:01:40PM +0000, Marc Zyngier wrote: > > Hi all, > > > > On Mon, 14 Feb 2022 16:20:13 +0000, > > Alexandru Elisei wrote: > > > > > > Hi Drew, > > > > > > (CC'ing Marc, he know more about 32 bit guest support than me) > > > > > > On Mon, Feb 14, 2022 at 03:24:44PM +0100, Andrew Jones wrote: > > > > I'm not sure it's worth adding another patch on top for that now, though. > > > > By the lack of new 32-bit arm unit tests getting submitted, I'm not even > > > > sure it's worth maintaining 32-bit arm at all... > > > > > > As far as I know, 32 bit guests are still very much supported and > > > maintained for KVM, so I think it would still be very useful to have the > > > tests. > > > > I can't force people to write additional tests (or even start writing > > the first one), but I'd like to reaffirm that AArch32 support still is > > a first class citizen when it comes to KVM/arm64. > > > > It has been tremendously useful even in the very recent past to debug > > issues that were plaguing bare metal Linux, and i don't plan to get > > rid of it anytime soon (TBH, it is too small to even be noticeable). > > > > OK, let's keep 32-bit arm support in kvm-unit-tests, at least as long as > we can find hardware to test it with (I still have access to a mustang). That HW will be with us for a *very* long time, given how popular things like A53 and A72 have been (and still are). > Does kvmtool support launching AArch32 guests? If so, then I suppose we > should also test kvmtool + 32-bit arm kvm-unit-tests. It does. Passing --aarch32 as a parameter results in AArch32 EL1 being selected. The only thing that doesn't work with kvmtool and this flag is the kvmtool-provided init when booting a 32bit kernel directly (we only carry a 64bit version). This should not affect unit tests, which are standalone. Thanks, M. -- Without deviation from the norm, progress is not possible.