From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FBFC433E1 for ; Fri, 29 May 2020 12:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 827F1206F0 for ; Fri, 29 May 2020 12:08:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="al4aZyJY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726161AbgE2MIl (ORCPT ); Fri, 29 May 2020 08:08:41 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:47539 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725306AbgE2MIh (ORCPT ); Fri, 29 May 2020 08:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590754116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gkkeI9/4O+LTTEQ+7u8ZuAx4cOWBRh3lwyxYXdlPlcc=; b=al4aZyJYU94MDwvF+FvnyFyrlIsw9/0MyGb+byotId1bUnf6erOdk0nmbAJexbB19dXT8s j2UVZRGR6oCvk2GM/FnforXL0H8lZ/9MZ//yv3YUrS8fwN7+VS7zTtPEyfBAMMIg3IIeOQ JEws5N7NZiEeY+TTMnSi+/YXCHT6KNg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-FG9SJq-kMJOH4DU5vB5AQg-1; Fri, 29 May 2020 08:08:34 -0400 X-MC-Unique: FG9SJq-kMJOH4DU5vB5AQg-1 Received: by mail-wm1-f71.google.com with SMTP id b65so609117wmb.5 for ; Fri, 29 May 2020 05:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=gkkeI9/4O+LTTEQ+7u8ZuAx4cOWBRh3lwyxYXdlPlcc=; b=i+JMqCPF6qSLljNGBVlWxoSKkZwegWIofT7N/hnJ3fp1c4WCpAinjJpwZ/YG0yCbTD 9N1LfAALHf0IarrL+qzsDaAmVgUmE1WQ6QB6UZkKwsKP7JHyeSTngyodeeP7ZExvcZON gqWmokKn58Slb+Lal0ItMD7fCB7hfrJyUx5nSDmaF0tCRB0ChzQjm+EzNkG8yyhlPi4r YWHNlSC1gH2BCUM2Y2SuRkRPPi+f8iQavtTElwhvO6nvyr0X8huFaGMRacKC2gJ4JA4g Rmp/WfNH2oSrFe3MzQh4+F6gvDOe91muAVdDJ9xAFsOy4Tz4p/7MCyvcScTErs4dqNAA HRBA== X-Gm-Message-State: AOAM530TTI2akXDEQJqAgYonjQRmGDH1TsmyY4VpXmIOjISYwibkuWXD cRWObxiz5VdEVKxk+f0ibfiDCBdtqC/UWHpfH1eua6OTSVEs3y0dMPjffGs47LrepUk3mCEP9C3 htIfcVevBsiOV X-Received: by 2002:a7b:cb0a:: with SMTP id u10mr7719805wmj.146.1590754113455; Fri, 29 May 2020 05:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIUKYN6RpJQ13GHibiYf05FEqiCpNM7pxTEl/HoRQDNE4g/S/lPW2gzkydzA3AWHeqXJVAog== X-Received: by 2002:a7b:cb0a:: with SMTP id u10mr7719792wmj.146.1590754113190; Fri, 29 May 2020 05:08:33 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id p65sm9911728wmp.36.2020.05.29.05.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 05:08:32 -0700 (PDT) From: Vitaly Kuznetsov To: Paolo Bonzini Cc: Jon Doron , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH v11 4/7] x86/kvm/hyper-v: Add support for synthetic debugger capability In-Reply-To: <12df4348-3dc1-a4cc-aa41-4492cd42dcc8@redhat.com> References: <20200424113746.3473563-1-arilou@gmail.com> <20200424113746.3473563-5-arilou@gmail.com> <12df4348-3dc1-a4cc-aa41-4492cd42dcc8@redhat.com> Date: Fri, 29 May 2020 14:08:31 +0200 Message-ID: <87ftbjhrk0.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Paolo Bonzini writes: > On 24/04/20 13:37, Jon Doron wrote: >> +static int syndbg_get_msr(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata, bool host) >> +{ >> + struct kvm_hv_syndbg *syndbg = vcpu_to_hv_syndbg(vcpu); >> + >> + if (!syndbg->active && !host) >> + return 1; >> + > > One small thing: is the ENABLE_CAP and active field needed? Can you > just check if the guest has the syndbg CPUID bits set? > Yes, we can probably get away with a static capability (so userspace knows that the interface is supported and CPUID bit can be set) and check guest_cpuid_has() here but we don't have Hyper-V feature leaves exposed as X86_FEATURE_* (yet). It is probably possible to implement an interim solution by open coding the check with kvm_find_cpuid_entry() or something like that. -- Vitaly